Hi folks,
As of today, all of the tests pass, and I believe all the comments
have been addressed. At the time of the triage one of the style tests
wasn't passing, but I would propose that it now be merged since that
issue has since been remedied.
Unless there are extremely strong objections (in addition to the
objections raised here and in the PR) I think it should be merged.
This is exciting! I can't wait to see this in the wild.
Thanks,
Matt
On Wed, Mar 9, 2016 at 12:22 PM, Matthew Turk
On Wed, Mar 9, 2016 at 12:19 PM, Nathan Goldbaum
wrote: On Wed, Mar 9, 2016 at 12:16 PM, Matthew Turk
wrote: On Wed, Mar 9, 2016 at 12:06 PM, Andrew Myers
wrote: OK, sounds good. I'll work on some docs as soon as possible, and hopefully if they get in we can be set up to accept it before any 3.3 release. Andrew, you're 3.3 manager, right? What's the 3.3 timescale?
There currently isn't a set time table, but I'd say it can be ready "soon." We knocked out a big chunk of the remaining VR issues last week. The only things that remain are 1) documenting and sanity checking the log / linear issue for Transfer functions, and 2) addressing the issues with the default alpha settings. I believe that all the other things we wanted to get done by 3.3 are in there.
Sounds good. I will get the docs done right away, by end of week; are there any code changes we should aim for in the OpenGL in addition?
No idea how hard this would be, but maybe something that prints some help text to the screen?
Great idea. Also, I should have solicited these requests to be added to the PR in comments, as they'll be easier to manage there.
Right now you need to look at the source code to see the keybindings.
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org