Good idea, I’ll send an email to yt-users.
On Thu, Dec 13, 2018 at 4:47 PM John ZuHone
Well, the current calculation is obviously not correct (I have never seen a calculation of angular momentum that wasn’t r x p).
Is there a way to efficiently notify a lot of users who may be using master besides emailing yt-users? That seems fine to me.
*Dr. John ZuHone*
*Astrophysicist, Chandra X-ray CenterCenter for Astrophysics | Harvard & Smithsonian*
Office: (617) 496 1816 | Cell: (781) 708 5004 60 Garden Street | MS 03 | Cambridge, MA 02138 john.zuhone@cfa.harvard.edu http://hea-www.cfa.harvard.edu/~jzuhone
On Dec 13, 2018, at 5:37 PM, Nathan Goldbaum
wrote: Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan
_______________________________________________
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org