This is awesome, and I am really impressed you've already issued a PR with an implementation along with a YTEP. I think your plan sounds good, and I will provide feedback on both the PR and the YTEP. I think this type of thing is going to be very useful.
On Thu, Jul 30, 2015 at 7:49 PM, Bili Dong firstname.lastname@example.org wrote:
Currently in yt, only the default cubic spline kernel function is provided and used for the smoothing. I’m thinking about adding more kernel functions, providing the possibility to choose from them and also the possibility for the users to provide their own ones. In my own research, a quintic spline kernel is used, for example. So I guess this functionality might also be useful for other users.
My current plan goes like this:
- Add several common kernel functions besides the current one.
- Build a naming system.
- Put a kwarg in appropriate places to pass the name of the kernel function. For now, I’m thinking about put it in the ParticleSmoothOperation class as a parameter of __init__.
- Reserve a special kwarg value which can be used to pass the user-provided kernel functions.
I’m not much experienced with yt. So correct me if there are any mistakes or omissions! Any suggestions are much appreciated!
Thanks, Bili _______________________________________________ yt-dev mailing list email@example.com http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org