Jeff, Britton, 

Thanks for the responses.  It's not clear to me what data it was grabbing before either.  I've gone ahead and pushed the changes for DivV using pf.dimensionality to determine what to include for both 1D and 2D. 

Best,
Sam

On Wed, Jul 13, 2011 at 3:50 AM, Britton Smith <brittonsmith@gmail.com> wrote:
Hey Sam,

It's not clear to me why it doesn't work without the if statement around the z dimension.  What data would it be getting in that case?

Either way, I think adding the if statement is good, because the calculation does not need to be done.  Perhaps for generality, it's worth putting the y dimension calculation in an if statement as well so that this also works in 1D.

Britton


On Tue, Jul 12, 2011 at 7:05 PM, j s oishi <jsoishi@gmail.com> wrote:
Hi Sam,

I looked over the ValidateSpatial briefly, but I'm not sure I
understand it. However,

> I could see us using a fix that does something like:
>     if len(data.pf.dimensions) > 2:
>         ds = div_fac * data['dz'].flat[0]
>         f += data["z-velocity"][1:-1,1:-1,sl_right]/ds
>         f -= data["z-velocity"][1:-1,1:-1,sl_left ]/ds

seems pretty reasonable to me.

j
_______________________________________________
Yt-dev mailing list
Yt-dev@lists.spacepope.org
http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org


_______________________________________________
Yt-dev mailing list
Yt-dev@lists.spacepope.org
http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org