Unless I am mistaken, the problem is that load() runs through all of the _is_valid's regardless.

John ZuHone
Laboratory for High-Energy Astrophysics
NASA/Goddard Space Flight Center
8800 Greenbelt Rd., Mail Code 662
Greenbelt, MD 20771
(w) 301-286-2531
(m) 781-708-5004
john.zuhone@nasa.gov
jzuhone@gmail.com

On Apr 10, 2014, at 7:32 PM, "B.W. Keller" <kellerbw@mcmaster.ca> wrote:

Oh my.  Sorry that I have introduced this, unfortunately there is no way to detect tipsy files other than actually reading the entire file from disk.  Perhaps the way to fix this would be to drop the priority of tipsy datasets to the bottom, so that a valid FLASH dataset will be detected prior to the Tipsy check?


On Thu, Apr 10, 2014 at 7:15 PM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,

We just had a bug report from Aaron Smith at UT Austin.  The symptom is that the "load" comman was taking 30 seconds to complete on his FLASH dataset, which should never happen for FLASH.

After asking him to profile the code, he produced the following profile:


It seems that the recent changes to the Tipsy frontend which allow it to autodetect binary outputs have made it so in some cases non-tipsy data is loaded off disk.

I'm not sure about the best way to handle this, which is why I'm writing to the list rather than issuing a PR.

-Nathan


_______________________________________________
yt-dev mailing list
yt-dev@lists.spacepope.org
http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org