Advice on geo projection PR to master vs. yt-4.0
Hi all, I've been working on building in support for cartopy projections for geographic data in yt. My PR for this work is here: https://github.com/yt-project/yt/pull/1966 I've submitted the PR to be merged into master, but I wanted to get some advice from you all if this should be changed to yt-4.0. It adds in some newer functionality that's not directly targeted for the yt 3.5 release. Another option could be to submit it to master but merge after the 3.5 release. Do you all have any advice or preference on where this should go or what the process should be here? Best, Madicken
Hi Madicken, My preference is that, since we don't have anything necessary for it in 4.0 and it does not break/change existing functionality, if it passes review master would be a good target. -Matt On Fri, Aug 24, 2018 at 2:57 PM Madicken Munk <madicken.munk@gmail.com> wrote:
I think targeting master after 3.5 goes out makes the most sense. That’s just me though. I think the main concern is that we want to make it easy for people to test this and experiment with it and we also don’t want to expose users to possibly experimental features and code. That means it shpuldn’t be in 3.5. It could go into the yt-4.0 branch but that makes it epsilon harder to install (not the default branch in the repo, cykdtree requires a bit of care to deal with atm) That also gives us some time to let this marinate a bit and get feedback from people. On Fri, Aug 24, 2018 at 2:57 PM Madicken Munk <madicken.munk@gmail.com> wrote:
Hi Madicken, My preference is that, since we don't have anything necessary for it in 4.0 and it does not break/change existing functionality, if it passes review master would be a good target. -Matt On Fri, Aug 24, 2018 at 2:57 PM Madicken Munk <madicken.munk@gmail.com> wrote:
I think targeting master after 3.5 goes out makes the most sense. That’s just me though. I think the main concern is that we want to make it easy for people to test this and experiment with it and we also don’t want to expose users to possibly experimental features and code. That means it shpuldn’t be in 3.5. It could go into the yt-4.0 branch but that makes it epsilon harder to install (not the default branch in the repo, cykdtree requires a bit of care to deal with atm) That also gives us some time to let this marinate a bit and get feedback from people. On Fri, Aug 24, 2018 at 2:57 PM Madicken Munk <madicken.munk@gmail.com> wrote:
participants (3)
-
Madicken Munk -
Matthew Turk -
Nathan Goldbaum