Why was max_level removed from the Projection data object?
Hi all, Does anyone remember why max_level was removed from the projection data object? It looks like the max_level keyword argument in ProjectionPlot is vestigial, and currently is only present in the API and doesn't actually do anything. I don't think it would be crazy make max_level work again, but I don't have context about why it was removed in the first place. Thanks for any insight anyone can provide, -Nathan
I'm sure it was my campaign against keyword arguments, but it looks like it was only a partial success. Probably a good idea to put it back in, even though I have my objections, since constructing a data object that collects grids up to a max level is probably overkill. On Wed, Jul 29, 2015 at 5:26 PM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Does anyone remember why max_level was removed from the projection data object?
It looks like the max_level keyword argument in ProjectionPlot is vestigial, and currently is only present in the API and doesn't actually do anything.
I don't think it would be crazy make max_level work again, but I don't have context about why it was removed in the first place.
Thanks for any insight anyone can provide,
-Nathan
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Ok, I'll try to track down the commit that killed the kwarg and see if it can be easily undone. On Wednesday, July 29, 2015, Matthew Turk <matthewturk@gmail.com> wrote:
I'm sure it was my campaign against keyword arguments, but it looks like it was only a partial success. Probably a good idea to put it back in, even though I have my objections, since constructing a data object that collects grids up to a max level is probably overkill.
On Wed, Jul 29, 2015 at 5:26 PM, Nathan Goldbaum <nathan12343@gmail.com <javascript:;>> wrote:
Hi all,
Does anyone remember why max_level was removed from the projection data object?
It looks like the max_level keyword argument in ProjectionPlot is vestigial, and currently is only present in the API and doesn't actually do anything.
I don't think it would be crazy make max_level work again, but I don't have context about why it was removed in the first place.
Thanks for any insight anyone can provide,
-Nathan
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org <javascript:;> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org <javascript:;> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (2)
-
Matthew Turk
-
Nathan Goldbaum