Move sanitization routines into coordinate handlers?
Hi all, especially Nathan, What do you think about moving the functions: get_sanitized_center get_sanitized_width get_window_parameters get_oblique_window_parameters into the coordinate handler (ds.coordinates)? This would make it easier to implement them more carefully and clearly for the different coordinate systems, like spherical, cylindrical, etc. -Matt
+1, since I ended up using them in other places than plot_window already.
On Aug 5, 2014, at 12:13 PM, Matthew Turk
Hi all, especially Nathan,
What do you think about moving the functions:
get_sanitized_center get_sanitized_width get_window_parameters get_oblique_window_parameters
into the coordinate handler (ds.coordinates)? This would make it easier to implement them more carefully and clearly for the different coordinate systems, like spherical, cylindrical, etc.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
On Tue, Aug 5, 2014 at 9:13 AM, Matthew Turk
Hi all, especially Nathan,
What do you think about moving the functions:
get_sanitized_center get_sanitized_width
I think it makes sense to put these in the coordinate handler.
get_window_parameters get_oblique_window_parameters
Less so these. Right now these functions have a lot of coordinate-specific logic in them, but I think most of that can be refactored into get_santized_center and get_sanitized_width.
into the coordinate handler (ds.coordinates)? This would make it easier to implement them more carefully and clearly for the different coordinate systems, like spherical, cylindrical, etc.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hi Nathan,
Fair enough.
I've been working through this and refactoring them, and I'll be
updating my PR not to be WIP as soon as I've finished.
One modification I'm considering making is allowing the center
sanitization to take an axis argument.
-Matt
On Tue, Aug 5, 2014 at 12:06 PM, Nathan Goldbaum
On Tue, Aug 5, 2014 at 9:13 AM, Matthew Turk
wrote: Hi all, especially Nathan,
What do you think about moving the functions:
get_sanitized_center get_sanitized_width
I think it makes sense to put these in the coordinate handler.
get_window_parameters get_oblique_window_parameters
Less so these. Right now these functions have a lot of coordinate-specific logic in them, but I think most of that can be refactored into get_santized_center and get_sanitized_width.
into the coordinate handler (ds.coordinates)? This would make it easier to implement them more carefully and clearly for the different coordinate systems, like spherical, cylindrical, etc.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (3)
-
John ZuHone
-
Matthew Turk
-
Nathan Goldbaum