Regression for particle deposition
Hi all, As a quick note, on my laptop I found a regression in particle deposition. The snapshot_033 ("deposit","all_density") is messed up. It was my fault, as it came from changeset 2dc75b72d271 and is a result of F/C ordering (and I can fix as soon as I am back at my desk in an hour or so). Should only affect octree particle deposition, went in very briefly, and I've CC'd everyone who might have been affected in the last two days. But, to the point, I'm not sure why the answer testing didn't catch this. Kacper, any ideas? -Matt
There is only answer testing for enzo at the moment: http://tests.yt-project.org/job/py2.7-yt-3.0_testing/ On Saturday, June 14, 2014, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
As a quick note, on my laptop I found a regression in particle deposition. The snapshot_033 ("deposit","all_density") is messed up. It was my fault, as it came from changeset 2dc75b72d271 and is a result of F/C ordering (and I can fix as soon as I am back at my desk in an hour or so). Should only affect octree particle deposition, went in very briefly, and I've CC'd everyone who might have been affected in the last two days.
But, to the point, I'm not sure why the answer testing didn't catch this. Kacper, any ideas?
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org <javascript:;> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hi, I'm sorry about that. Last time I've checked answers for other things besides Enzo, they were having runtime issues i.e. they were throwing errors even with --with-answer-store. But that was sometime ago. I'll try to setup remaining tests asap (unfortunately this means Monday at best) Cheers, Kacper On Jun 14, 2014 8:30 PM, "Nathan Goldbaum" <nathan12343@gmail.com> wrote:
There is only answer testing for enzo at the moment:
http://tests.yt-project.org/job/py2.7-yt-3.0_testing/
On Saturday, June 14, 2014, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
As a quick note, on my laptop I found a regression in particle deposition. The snapshot_033 ("deposit","all_density") is messed up. It was my fault, as it came from changeset 2dc75b72d271 and is a result of F/C ordering (and I can fix as soon as I am back at my desk in an hour or so). Should only affect octree particle deposition, went in very briefly, and I've CC'd everyone who might have been affected in the last two days.
But, to the point, I'm not sure why the answer testing didn't catch this. Kacper, any ideas?
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hi Kacper & Nathan, No, actually, please don't rush on it -- sounds like it was doing everything it was supposed to, and I was falsely relying on the tests. I'll be issuing a fix asap, and I will then take a look at all of the answer tests to figure out what the deal is. -Matt On Sat, Jun 14, 2014 at 3:11 PM, Kacper Kowalik <xarthisius.kk@gmail.com> wrote:
Hi, I'm sorry about that. Last time I've checked answers for other things besides Enzo, they were having runtime issues i.e. they were throwing errors even with --with-answer-store. But that was sometime ago. I'll try to setup remaining tests asap (unfortunately this means Monday at best) Cheers, Kacper
On Jun 14, 2014 8:30 PM, "Nathan Goldbaum" <nathan12343@gmail.com> wrote:
There is only answer testing for enzo at the moment: http://tests.yt-project.org/job/py2.7-yt-3.0_testing/
On Saturday, June 14, 2014, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
As a quick note, on my laptop I found a regression in particle deposition. The snapshot_033 ("deposit","all_density") is messed up. It was my fault, as it came from changeset 2dc75b72d271 and is a result of F/C ordering (and I can fix as soon as I am back at my desk in an hour or so). Should only affect octree particle deposition, went in very briefly, and I've CC'd everyone who might have been affected in the last two days.
But, to the point, I'm not sure why the answer testing didn't catch this. Kacper, any ideas?
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hey Matt, Thanks - does this mean that any commit after the 2dc75b72d271 would have the regressed octree deposition, or that updating to changesets after that means we see the 'new' octree particle deposition. -desika On Sat, Jun 14, 2014 at 2:13 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
As a quick note, on my laptop I found a regression in particle deposition. The snapshot_033 ("deposit","all_density") is messed up. It was my fault, as it came from changeset 2dc75b72d271 and is a result of F/C ordering (and I can fix as soon as I am back at my desk in an hour or so). Should only affect octree particle deposition, went in very briefly, and I've CC'd everyone who might have been affected in the last two days.
But, to the point, I'm not sure why the answer testing didn't catch this. Kacper, any ideas?
-Matt
Hi Desika, Yup. I've issued a PR to fix it. -Matt On Sat, Jun 14, 2014 at 3:59 PM, Desika Narayanan <dnarayan@haverford.edu> wrote:
Hey Matt,
Thanks - does this mean that any commit after the 2dc75b72d271 would have the regressed octree deposition, or that updating to changesets after that means we see the 'new' octree particle deposition.
-desika
On Sat, Jun 14, 2014 at 2:13 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
As a quick note, on my laptop I found a regression in particle deposition. The snapshot_033 ("deposit","all_density") is messed up. It was my fault, as it came from changeset 2dc75b72d271 and is a result of F/C ordering (and I can fix as soon as I am back at my desk in an hour or so). Should only affect octree particle deposition, went in very briefly, and I've CC'd everyone who might have been affected in the last two days.
But, to the point, I'm not sure why the answer testing didn't catch this. Kacper, any ideas?
-Matt
participants (4)
-
Desika Narayanan -
Kacper Kowalik -
Matthew Turk -
Nathan Goldbaum