Fwd: [Numpy-discussion] PR Cleanup
This seems worth doing. I can reach out to the astropy people about setting this up for yt. Do others think this would be worthwhile?
---------- Forwarded message --------- From: Marten van Kerkwijk m.h.vankerkwijk@gmail.com Date: Tue, Sep 25, 2018 at 1:36 PM Subject: Re: [Numpy-discussion] PR Cleanup To: Discussion of Numerical Python numpy-discussion@python.org
Hi Chuck,
Over at astropy we have a bot that sends a warning to PRs that have not received any commits for 5 months [1] and closes them if nothing happens in the next month, asking to open an issue instead. Despite my apprehensions, I found this worked quite well, drawing back attention to forgotten PRs (and forcing one to consider if they best remain forgotten).
Would there be interest in such a scheme?
All the best,
Marten
p.s. We don't do anything with issues.
[1] Text of the astropy-bot warning:
Hi humans [image: wave] - this pull request hasn't had any new commits for approximately 5 months. *I plan to close this in a month if the pull request doesn't have any new commits by then.*
In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.
If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list http://groups.google.com/group/astropy-dev .
*If you believe I commented on this pull request incorrectly, please report this here https://github.com/astropy/astropy-bot/issues.*
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion
+1
On Tue, Sep 25, 2018 at 10:47 AM, Nathan Goldbaum nathan12343@gmail.com wrote:
This seems worth doing. I can reach out to the astropy people about setting this up for yt. Do others think this would be worthwhile?
---------- Forwarded message --------- From: Marten van Kerkwijk m.h.vankerkwijk@gmail.com Date: Tue, Sep 25, 2018 at 1:36 PM Subject: Re: [Numpy-discussion] PR Cleanup To: Discussion of Numerical Python numpy-discussion@python.org
Hi Chuck,
Over at astropy we have a bot that sends a warning to PRs that have not received any commits for 5 months [1] and closes them if nothing happens in the next month, asking to open an issue instead. Despite my apprehensions, I found this worked quite well, drawing back attention to forgotten PRs (and forcing one to consider if they best remain forgotten).
Would there be interest in such a scheme?
All the best,
Marten
p.s. We don't do anything with issues.
[1] Text of the astropy-bot warning:
Hi humans [image: wave] - this pull request hasn't had any new commits for approximately 5 months. *I plan to close this in a month if the pull request doesn't have any new commits by then.*
In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.
If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list http://groups.google.com/group/astropy-dev.
*If you believe I commented on this pull request incorrectly, please report this here https://github.com/astropy/astropy-bot/issues.*
NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
As the author of several PRs that I want to return to, I am a strong -0 on this.
On Tue, Sep 25, 2018 at 12:48 PM Nathan Goldbaum nathan12343@gmail.com wrote:
This seems worth doing. I can reach out to the astropy people about setting this up for yt. Do others think this would be worthwhile?
---------- Forwarded message --------- From: Marten van Kerkwijk m.h.vankerkwijk@gmail.com Date: Tue, Sep 25, 2018 at 1:36 PM Subject: Re: [Numpy-discussion] PR Cleanup To: Discussion of Numerical Python numpy-discussion@python.org
Hi Chuck,
Over at astropy we have a bot that sends a warning to PRs that have not received any commits for 5 months [1] and closes them if nothing happens in the next month, asking to open an issue instead. Despite my apprehensions, I found this worked quite well, drawing back attention to forgotten PRs (and forcing one to consider if they best remain forgotten).
Would there be interest in such a scheme?
All the best,
Marten
p.s. We don't do anything with issues.
[1] Text of the astropy-bot warning:
Hi humans [image: wave] - this pull request hasn't had any new commits for approximately 5 months. *I plan to close this in a month if the pull request doesn't have any new commits by then.*
In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.
If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list http://groups.google.com/group/astropy-dev.
*If you believe I commented on this pull request incorrectly, please report this here https://github.com/astropy/astropy-bot/issues.*
NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
I was going to say I liked it until I saw Matt's -0. But the "rebase to reset the clock" bit seems like a good way to keep things alive.
On Tue, Sep 25, 2018 at 1:51 PM Matthew Turk matthewturk@gmail.com wrote:
As the author of several PRs that I want to return to, I am a strong -0 on this.
On Tue, Sep 25, 2018 at 12:48 PM Nathan Goldbaum nathan12343@gmail.com wrote:
This seems worth doing. I can reach out to the astropy people about setting this up for yt. Do others think this would be worthwhile?
---------- Forwarded message --------- From: Marten van Kerkwijk m.h.vankerkwijk@gmail.com Date: Tue, Sep 25, 2018 at 1:36 PM Subject: Re: [Numpy-discussion] PR Cleanup To: Discussion of Numerical Python numpy-discussion@python.org
Hi Chuck,
Over at astropy we have a bot that sends a warning to PRs that have not received any commits for 5 months [1] and closes them if nothing happens in the next month, asking to open an issue instead. Despite my apprehensions, I found this worked quite well, drawing back attention to forgotten PRs (and forcing one to consider if they best remain forgotten).
Would there be interest in such a scheme?
All the best,
Marten
p.s. We don't do anything with issues.
[1] Text of the astropy-bot warning:
Hi humans [image: wave] - this pull request hasn't had any new commits for approximately 5 months. *I plan to close this in a month if the pull request doesn't have any new commits by then.*
In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.
If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list http://groups.google.com/group/astropy-dev.
*If you believe I commented on this pull request incorrectly, please report this here https://github.com/astropy/astropy-bot/issues.*
NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
Would the 1 month period to do something with the PR (including a rebase or merge as mike pointed out) be enough to assuage your concern here? Or maybe longer than a month?
My worry here is that we have a lot of older PRs in the queue, it would be really nice to have a list that is more immediately actionable.
On Tue, Sep 25, 2018 at 1:50 PM, Matthew Turk matthewturk@gmail.com wrote:
As the author of several PRs that I want to return to, I am a strong -0 on this.
On Tue, Sep 25, 2018 at 12:48 PM Nathan Goldbaum nathan12343@gmail.com wrote:
This seems worth doing. I can reach out to the astropy people about setting this up for yt. Do others think this would be worthwhile?
---------- Forwarded message --------- From: Marten van Kerkwijk m.h.vankerkwijk@gmail.com Date: Tue, Sep 25, 2018 at 1:36 PM Subject: Re: [Numpy-discussion] PR Cleanup To: Discussion of Numerical Python numpy-discussion@python.org
Hi Chuck,
Over at astropy we have a bot that sends a warning to PRs that have not received any commits for 5 months [1] and closes them if nothing happens in the next month, asking to open an issue instead. Despite my apprehensions, I found this worked quite well, drawing back attention to forgotten PRs (and forcing one to consider if they best remain forgotten).
Would there be interest in such a scheme?
All the best,
Marten
p.s. We don't do anything with issues.
[1] Text of the astropy-bot warning:
Hi humans [image: wave] - this pull request hasn't had any new commits for approximately 5 months. *I plan to close this in a month if the pull request doesn't have any new commits by then.*
In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.
If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list http://groups.google.com/group/astropy-dev.
*If you believe I commented on this pull request incorrectly, please report this here https://github.com/astropy/astropy-bot/issues.*
NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
No, it's fine, don't worry about it. On Tue, Sep 25, 2018 at 1:09 PM Nathan Goldbaum nathan12343@gmail.com wrote:
Would the 1 month period to do something with the PR (including a rebase or merge as mike pointed out) be enough to assuage your concern here? Or maybe longer than a month?
My worry here is that we have a lot of older PRs in the queue, it would be really nice to have a list that is more immediately actionable.
On Tue, Sep 25, 2018 at 1:50 PM, Matthew Turk matthewturk@gmail.com wrote:
As the author of several PRs that I want to return to, I am a strong -0 on this.
On Tue, Sep 25, 2018 at 12:48 PM Nathan Goldbaum nathan12343@gmail.com wrote:
This seems worth doing. I can reach out to the astropy people about setting this up for yt. Do others think this would be worthwhile?
---------- Forwarded message --------- From: Marten van Kerkwijk m.h.vankerkwijk@gmail.com Date: Tue, Sep 25, 2018 at 1:36 PM Subject: Re: [Numpy-discussion] PR Cleanup To: Discussion of Numerical Python numpy-discussion@python.org
Hi Chuck,
Over at astropy we have a bot that sends a warning to PRs that have not received any commits for 5 months [1] and closes them if nothing happens in the next month, asking to open an issue instead. Despite my apprehensions, I found this worked quite well, drawing back attention to forgotten PRs (and forcing one to consider if they best remain forgotten).
Would there be interest in such a scheme?
All the best,
Marten
p.s. We don't do anything with issues.
[1] Text of the astropy-bot warning:
Hi humans - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.
In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.
If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list.
If you believe I commented on this pull request incorrectly, please report this here.
NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
participants (4)
-
Cameron Hummels -
Matthew Turk -
Michael Zingale -
Nathan Goldbaum