Hi all, Nathan and I sprinted on a few remaining things for the unit refactor, to the point that I would like to see it get tried out and tested in production. Casey and Nathan have done some really cool stuff with the units work, and I think it will be awesome. I've issued a PR against the tip of the yt-3.0 branch. Nathan and I will likely be updating this throughout the day. https://bitbucket.org/yt_analysis/yt/pull-request/662/unit-refactor What works: * All of the non-VR *unit* tests * Plotting of things * Units on arrays! Each frontend needs to be manually converted, as fields are now completely redone -- and much nicer. We have redone: * Enzo * FLASH * RAMSES * Boxlib (mostly) * Stream However, before we got too far down the road, I wanted to verify that things are heading in a direction the developers are happy with. Specifically, things like the way fields are created (check out yt/fields/*.py and the frontends/*/fields.py for converted frontends) and the new UI for dealing with things. This *needs* to land in some form or another before the 3.0 release, and I'd like to start getting testing done now so that we can land the other big item, the rebranding. Unit refactor can't be accepted until: * We get some people to use it, say what's wrong. * The other frontends get converted. * The VR interface is fixed. * Plots have a unit-ful interface, which is mostly done. So, I'd like to ask that y'all try it out by pulling the bookmark unitrefactor from my fork ( MatthewTurk/yt ). On Thursday during the dev hangout at 2PM EST, this will be the biggest part of the agenda -- actually trying it out. -Matt
One note that Matt forgot to mention. This PR also includes an
implementation of YTEP-0003 (field renaming):
http://ytep.readthedocs.org/en/latest/YTEPs/YTEP-0003.html
Now all universal fields are named according to the YTEP. In fact the
entire field system has been completely revamped (and massively simplified
- it's a *big* improvement in my opinion). Keep that in mind when testing
it out.
For Enzo data the old field names will still be available, but they will
come up in internal code units. This is an improvement - it was a big pain
to get Enzo data in code units before - but it will probably be confusing
while people adjust their muscle memory to the new field names.
There is a compatibility layer that Matt added to alias the old field names
to the new ones but I'm not very familiar with it so I'll leave it to Matt
to comment on that.
-Nathan
On Tue, Dec 3, 2013 at 8:15 AM, Matthew Turk
Hi all,
Nathan and I sprinted on a few remaining things for the unit refactor, to the point that I would like to see it get tried out and tested in production. Casey and Nathan have done some really cool stuff with the units work, and I think it will be awesome.
I've issued a PR against the tip of the yt-3.0 branch. Nathan and I will likely be updating this throughout the day.
https://bitbucket.org/yt_analysis/yt/pull-request/662/unit-refactor
What works:
* All of the non-VR *unit* tests * Plotting of things * Units on arrays!
Each frontend needs to be manually converted, as fields are now completely redone -- and much nicer. We have redone:
* Enzo * FLASH * RAMSES * Boxlib (mostly) * Stream
However, before we got too far down the road, I wanted to verify that things are heading in a direction the developers are happy with. Specifically, things like the way fields are created (check out yt/fields/*.py and the frontends/*/fields.py for converted frontends) and the new UI for dealing with things.
This *needs* to land in some form or another before the 3.0 release, and I'd like to start getting testing done now so that we can land the other big item, the rebranding.
Unit refactor can't be accepted until:
* We get some people to use it, say what's wrong. * The other frontends get converted. * The VR interface is fixed. * Plots have a unit-ful interface, which is mostly done.
So, I'd like to ask that y'all try it out by pulling the bookmark unitrefactor from my fork ( MatthewTurk/yt ). On Thursday during the dev hangout at 2PM EST, this will be the biggest part of the agenda -- actually trying it out.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
On Tue, Dec 3, 2013 at 10:24 AM, Nathan Goldbaum
One note that Matt forgot to mention. This PR also includes an implementation of YTEP-0003 (field renaming):
http://ytep.readthedocs.org/en/latest/YTEPs/YTEP-0003.html
Now all universal fields are named according to the YTEP. In fact the entire field system has been completely revamped (and massively simplified - it's a *big* improvement in my opinion). Keep that in mind when testing it out.
For Enzo data the old field names will still be available, but they will come up in internal code units. This is an improvement - it was a big pain to get Enzo data in code units before - but it will probably be confusing while people adjust their muscle memory to the new field names.
There is a compatibility layer that Matt added to alias the old field names to the new ones but I'm not very familiar with it so I'll leave it to Matt to comment on that.
Oh yeah! You can call pf._setup_deprecated_fields() to add on a compatibility layer for the old fields. That's relatively new though, so there might be holes in it somewhere. -Matt
-Nathan
On Tue, Dec 3, 2013 at 8:15 AM, Matthew Turk
wrote: Hi all,
Nathan and I sprinted on a few remaining things for the unit refactor, to the point that I would like to see it get tried out and tested in production. Casey and Nathan have done some really cool stuff with the units work, and I think it will be awesome.
I've issued a PR against the tip of the yt-3.0 branch. Nathan and I will likely be updating this throughout the day.
https://bitbucket.org/yt_analysis/yt/pull-request/662/unit-refactor
What works:
* All of the non-VR *unit* tests * Plotting of things * Units on arrays!
Each frontend needs to be manually converted, as fields are now completely redone -- and much nicer. We have redone:
* Enzo * FLASH * RAMSES * Boxlib (mostly) * Stream
However, before we got too far down the road, I wanted to verify that things are heading in a direction the developers are happy with. Specifically, things like the way fields are created (check out yt/fields/*.py and the frontends/*/fields.py for converted frontends) and the new UI for dealing with things.
This *needs* to land in some form or another before the 3.0 release, and I'd like to start getting testing done now so that we can land the other big item, the rebranding.
Unit refactor can't be accepted until:
* We get some people to use it, say what's wrong. * The other frontends get converted. * The VR interface is fixed. * Plots have a unit-ful interface, which is mostly done.
So, I'd like to ask that y'all try it out by pulling the bookmark unitrefactor from my fork ( MatthewTurk/yt ). On Thursday during the dev hangout at 2PM EST, this will be the biggest part of the agenda -- actually trying it out.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (2)
-
Matthew Turk
-
Nathan Goldbaum