A number of PRs in need of review

Hi folks, We have a number of PRs that are nearly ready to go but need some more review. Most of them (but not all) already have two approves and they have docs and tests completed. The ones I identify which qualify are: https://github.com/yt-project/yt/pull/1446 <https://github.com/yt-project/yt/pull/1446> https://github.com/yt-project/yt/pull/1435 <https://github.com/yt-project/yt/pull/1435> https://github.com/yt-project/yt/pull/1433 <https://github.com/yt-project/yt/pull/1433> https://github.com/yt-project/yt/pull/1430 <https://github.com/yt-project/yt/pull/1430> https://github.com/yt-project/yt/pull/1422 <https://github.com/yt-project/yt/pull/1422> https://github.com/yt-project/yt/pull/1421 <https://github.com/yt-project/yt/pull/1421> If we could get some help reviewing these and getting them merged in that would be great. Best, John

Hi John, A number of those are bugfixes, which I think we should feel comfortable to merge with two approves. I've been doing most of the PR merging lately, please feel free to hit the merge button yourself. -Nathan On Wed, Jun 14, 2017 at 11:13 AM, John Zuhone <jzuhone@gmail.com> wrote:
Hi folks,
We have a number of PRs that are nearly ready to go but need some more review. Most of them (but not all) already have two approves and they have docs and tests completed.
The ones I identify which qualify are:
https://github.com/yt-project/yt/pull/1446
https://github.com/yt-project/yt/pull/1435
https://github.com/yt-project/yt/pull/1433
https://github.com/yt-project/yt/pull/1430
https://github.com/yt-project/yt/pull/1422
https://github.com/yt-project/yt/pull/1421
If we could get some help reviewing these and getting them merged in that would be great.
Best,
John
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org

And if it's proving increasingly difficult to get three approvals for new features, maybe we should relax that requirement as well? On Wed, Jun 14, 2017 at 11:17 AM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi John,
A number of those are bugfixes, which I think we should feel comfortable to merge with two approves. I've been doing most of the PR merging lately, please feel free to hit the merge button yourself.
-Nathan
On Wed, Jun 14, 2017 at 11:13 AM, John Zuhone <jzuhone@gmail.com> wrote:
Hi folks,
We have a number of PRs that are nearly ready to go but need some more review. Most of them (but not all) already have two approves and they have docs and tests completed.
The ones I identify which qualify are:
https://github.com/yt-project/yt/pull/1446
https://github.com/yt-project/yt/pull/1435
https://github.com/yt-project/yt/pull/1433
https://github.com/yt-project/yt/pull/1430
https://github.com/yt-project/yt/pull/1422
https://github.com/yt-project/yt/pull/1421
If we could get some help reviewing these and getting them merged in that would be great.
Best,
John
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (2)
-
John Zuhone
-
Nathan Goldbaum