PR to remove Theia
Hi all, As part of my ongoing efforts to clean up the codebase, I just opened a pull request to remove the Theia hardware volume rendering interface from yt: https://bitbucket.org/yt_analysis/yt/pull-requests/1703/removing-theia-hardw... I'd only like to see this pull request merged if there's consensus that this is the way to go. I'd especially like to hear from anyone that is actually using this code, or if anyone is interested in maintaining it and adding tests. -Nathan
Hi Nathan, Your arguments in the pull request are persuasive, and I agree with this course of action. -Matt On Mon, Aug 17, 2015 at 11:58 AM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
As part of my ongoing efforts to clean up the codebase, I just opened a pull request to remove the Theia hardware volume rendering interface from yt:
https://bitbucket.org/yt_analysis/yt/pull-requests/1703/removing-theia-hardw...
I'd only like to see this pull request merged if there's consensus that this is the way to go. I'd especially like to hear from anyone that is actually using this code, or if anyone is interested in maintaining it and adding tests.
-Nathan
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
+1 John ZuHone Kavli Center for Astrophysics and Space Research Massachusetts Institute of Technology 77 Massachusetts Ave., 37-582G Cambridge, MA 02139 (w) 617-253-2354 (m) 781-708-5004 jzuhone@space.mit.edu jzuhone@gmail.com http://www.jzuhone.com
On Aug 17, 2015, at 12:58 PM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
As part of my ongoing efforts to clean up the codebase, I just opened a pull request to remove the Theia hardware volume rendering interface from yt:
https://bitbucket.org/yt_analysis/yt/pull-requests/1703/removing-theia-hardw...
I'd only like to see this pull request merged if there's consensus that this is the way to go. I'd especially like to hear from anyone that is actually using this code, or if anyone is interested in maintaining it and adding tests.
-Nathan _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
I agree. Unless someone is actively using this and makes a clear case for keeping it in, I think it should go. Cameron On Thu, Aug 20, 2015 at 9:30 AM, John ZuHone <jzuhone@gmail.com> wrote:
+1
John ZuHone Kavli Center for Astrophysics and Space Research Massachusetts Institute of Technology 77 Massachusetts Ave., 37-582G Cambridge, MA 02139 (w) 617-253-2354 (m) 781-708-5004 jzuhone@space.mit.edu jzuhone@gmail.com http://www.jzuhone.com
On Aug 17, 2015, at 12:58 PM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
As part of my ongoing efforts to clean up the codebase, I just opened a pull request to remove the Theia hardware volume rendering interface from yt:
https://bitbucket.org/yt_analysis/yt/pull-requests/1703/removing-theia-hardw...
I'd only like to see this pull request merged if there's consensus that this is the way to go. I'd especially like to hear from anyone that is actually using this code, or if anyone is interested in maintaining it and adding tests.
-Nathan
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels NSF Postdoctoral Fellow Department of Astronomy California Institute of Technology http://chummels.org
participants (4)
-
Cameron Hummels -
John ZuHone -
Matthew Turk -
Nathan Goldbaum