GDF PR--call for some feedback
Hi all, I have a work-in-progress PR in the hopper regarding GDF reading and writing: https://bitbucket.org/yt_analysis/yt/pull-request/1001/wip-some-gdf-writing-... What it does is implement direct writing of covering grids to GDF files (something I've been using in my research, to work with the resulting files directly in yt) and clobbering existing files with the same path if the user allows for it. However, when fiddling around with this I determined that it was necessary to make GDF more unit-aware. Ultimately, I determined that changes were needed that would break the standard that we had determined for the files (http://yt-project.org/gdf.txt). The two main changes are: 1) Remove "field_to_cgs", and allow the fields to be in whatever units we wish them to be in the file (which are specified as HDF5 attributes). 2) Add a new top-level group containing the information for "length","mass", and "time" units. These will be used when the file is opened up in yt to determine the units. Since (for now) we do automatic conversion to cgs, that is something that is still left unimplemented, but otherwise I think this is all to do for now. I'm writing the email in case anyone has any suggestions or objections to the format changes--particularly Jeff or Kacper. We'll obviously need to document them if they are accepted. Best, John -- John ZuHone Postdoctoral Researcher NASA/Goddard Space Flight Center jzuhone@gmail.com john.zuhone@nasa.gov
participants (8)
-
Cameron Hummels
-
John Zuhone
-
John ZuHone
-
Kacper Kowalik
-
Matthew Turk
-
Michael Zingale
-
Nathan Goldbaum
-
Stuart Mumford