Status of a few big PRs
Hi all,
There are a few big PRs still open. I wanted to update you on them:
* VR refactor: https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-... . This is ready for review.
* Particle octree refactor: https://bitbucket.org/yt_analysis/yt/pull-request/1206/wip-forest-of-octrees . This will simply not work in its current form. I have redesigned it around nested bitmap indices but not yet pushed to my fork; I'm hoping to get to it sometime in the next few weeks.
* Hybrid Rockstar: https://bitbucket.org/yt_analysis/yt/pull-request/1618/wip-hybrid-rockstar . Hilary has done some awesome work on this, and I think that it will work nicely, but parallelism might need some help (according to her bullet points)
* Grid visitors: The preliminary PR was accepted, and I am working on a new set of PRs that will enable this broadly. This should reduce memory overhead.
* OpenGL volume rendering: https://bitbucket.org/yt_analysis/yt/pull-request/1598/opengl-volume-renderi... . This is blocked on the VR refactor, and once that is in I'll continue to update this to utilize the new scene objects.
-Matt
Hi Matt,
VR refactor’s tests all pass and we have three approvals already. Are we raising the bar higher for including this one?
If we are, we should probably specify how many approvals we need. If not, then we should just merge it.
Best,
John
On Jun 22, 2015, at 1:18 PM, Matthew Turk matthewturk@gmail.com wrote:
Hi all,
There are a few big PRs still open. I wanted to update you on them:
- VR refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-... . This is ready for review.
- Particle octree refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1206/wip-forest-of-octrees . This will simply not work in its current form. I have redesigned it around nested bitmap indices but not yet pushed to my fork; I'm hoping to get to it sometime in the next few weeks.
- Hybrid Rockstar:
https://bitbucket.org/yt_analysis/yt/pull-request/1618/wip-hybrid-rockstar . Hilary has done some awesome work on this, and I think that it will work nicely, but parallelism might need some help (according to her bullet points)
- Grid visitors: The preliminary PR was accepted, and I am working on
a new set of PRs that will enable this broadly. This should reduce memory overhead.
- OpenGL volume rendering:
https://bitbucket.org/yt_analysis/yt/pull-request/1598/opengl-volume-renderi... . This is blocked on the VR refactor, and once that is in I'll continue to update this to utilize the new scene objects.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
I've been meaning to play with this, but I've been traveling. I'll take a look later this week, but if others have already approved, then it may as well go in.
On Mon, Jun 22, 2015 at 5:11 PM, John Zuhone jzuhone@gmail.com wrote:
Hi Matt,
VR refactor’s tests all pass and we have three approvals already. Are we raising the bar higher for including this one?
If we are, we should probably specify how many approvals we need. If not, then we should just merge it.
Best,
John
On Jun 22, 2015, at 1:18 PM, Matthew Turk matthewturk@gmail.com wrote:
Hi all,
There are a few big PRs still open. I wanted to update you on them:
- VR refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-...
. This is ready for review.
- Particle octree refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1206/wip-forest-of-octrees
. This will simply not work in its current form. I have redesigned it around nested bitmap indices but not yet pushed to my fork; I'm hoping to get to it sometime in the next few weeks.
- Hybrid Rockstar:
https://bitbucket.org/yt_analysis/yt/pull-request/1618/wip-hybrid-rockstar
. Hilary has done some awesome work on this, and I think that it will work nicely, but parallelism might need some help (according to her bullet points)
- Grid visitors: The preliminary PR was accepted, and I am working on
a new set of PRs that will enable this broadly. This should reduce memory overhead.
- OpenGL volume rendering:
https://bitbucket.org/yt_analysis/yt/pull-request/1598/opengl-volume-renderi...
. This is blocked on the VR refactor, and once that is in I'll continue to update this to utilize the new scene objects.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
John:
Please do not merge this yet. As the main author of the ytep on the VR refactor, I have been meaning to look at it the last couple of weeks, but I had an unforeseen accident and surgery last weekend that prevented me from doing it. I will look at it in the next day or two. My main concern is that the functionality fits into the larger goals of the VR refactor in working with TimeSeries datasets instead of just working with single outputs, and I want to do a full review of the code to make sure everything works as advertised. I've started this, but it's a big merge, and it is taking some time. Given that this is a large undertaking and the key piece of they yt 3.2 release, I want to make sure it doesn't have any problems.
Cameron
On Mon, Jun 22, 2015 at 3:59 PM, Michael Zingale < michael.zingale@stonybrook.edu> wrote:
I've been meaning to play with this, but I've been traveling. I'll take a look later this week, but if others have already approved, then it may as well go in.
On Mon, Jun 22, 2015 at 5:11 PM, John Zuhone jzuhone@gmail.com wrote:
Hi Matt,
VR refactor’s tests all pass and we have three approvals already. Are we raising the bar higher for including this one?
If we are, we should probably specify how many approvals we need. If not, then we should just merge it.
Best,
John
On Jun 22, 2015, at 1:18 PM, Matthew Turk matthewturk@gmail.com
wrote:
Hi all,
There are a few big PRs still open. I wanted to update you on them:
- VR refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-...
. This is ready for review.
- Particle octree refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1206/wip-forest-of-octrees
. This will simply not work in its current form. I have redesigned it around nested bitmap indices but not yet pushed to my fork; I'm hoping to get to it sometime in the next few weeks.
- Hybrid Rockstar:
https://bitbucket.org/yt_analysis/yt/pull-request/1618/wip-hybrid-rockstar
. Hilary has done some awesome work on this, and I think that it will work nicely, but parallelism might need some help (according to her bullet points)
- Grid visitors: The preliminary PR was accepted, and I am working on
a new set of PRs that will enable this broadly. This should reduce memory overhead.
- OpenGL volume rendering:
https://bitbucket.org/yt_analysis/yt/pull-request/1598/opengl-volume-renderi...
. This is blocked on the VR refactor, and once that is in I'll continue to update this to utilize the new scene objects.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Michael Zingale Associate Professor
Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hi Cameron,
First, sorry to hear about your injury and surgery--I hope you're recovering ok and that you're able to get some rest.
I wasn't planning on merging it myself--just asking for clarification on why we weren't doing it yet, given that by our normal rules we would normally merge it. I definitely agree that we should wait until you and others have had a once-over.
I'm going to make a note of this on the PR.
Best,
John
John ZuHone Kavli Center for Astrophysics and Space Research Massachusetts Institute of Technology 77 Massachusetts Ave., 37-582G Cambridge, MA 02139 (w) 617-253-2354 (m) 781-708-5004 jzuhone@space.mit.edu jzuhone@gmail.com http://www.jzuhone.com
On Jun 22, 2015, at 7:49 PM, Cameron Hummels chummels@gmail.com wrote:
John:
Please do not merge this yet. As the main author of the ytep on the VR refactor, I have been meaning to look at it the last couple of weeks, but I had an unforeseen accident and surgery last weekend that prevented me from doing it. I will look at it in the next day or two. My main concern is that the functionality fits into the larger goals of the VR refactor in working with TimeSeries datasets instead of just working with single outputs, and I want to do a full review of the code to make sure everything works as advertised. I've started this, but it's a big merge, and it is taking some time. Given that this is a large undertaking and the key piece of they yt 3.2 release, I want to make sure it doesn't have any problems.
Cameron
On Mon, Jun 22, 2015 at 3:59 PM, Michael Zingale michael.zingale@stonybrook.edu wrote: I've been meaning to play with this, but I've been traveling. I'll take a look later this week, but if others have already approved, then it may as well go in.
On Mon, Jun 22, 2015 at 5:11 PM, John Zuhone jzuhone@gmail.com wrote: Hi Matt,
VR refactor’s tests all pass and we have three approvals already. Are we raising the bar higher for including this one?
If we are, we should probably specify how many approvals we need. If not, then we should just merge it.
Best,
John
On Jun 22, 2015, at 1:18 PM, Matthew Turk matthewturk@gmail.com wrote:
Hi all,
There are a few big PRs still open. I wanted to update you on them:
- VR refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-... . This is ready for review.
- Particle octree refactor:
https://bitbucket.org/yt_analysis/yt/pull-request/1206/wip-forest-of-octrees . This will simply not work in its current form. I have redesigned it around nested bitmap indices but not yet pushed to my fork; I'm hoping to get to it sometime in the next few weeks.
- Hybrid Rockstar:
https://bitbucket.org/yt_analysis/yt/pull-request/1618/wip-hybrid-rockstar . Hilary has done some awesome work on this, and I think that it will work nicely, but parallelism might need some help (according to her bullet points)
- Grid visitors: The preliminary PR was accepted, and I am working on
a new set of PRs that will enable this broadly. This should reduce memory overhead.
- OpenGL volume rendering:
https://bitbucket.org/yt_analysis/yt/pull-request/1598/opengl-volume-renderi... . This is blocked on the VR refactor, and once that is in I'll continue to update this to utilize the new scene objects.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Michael Zingale Associate Professor
Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 phone: 631-632-8225 e-mail: Michael.Zingale@stonybrook.edu web: http://www.astro.sunysb.edu/mzingale
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (5)
-
Cameron Hummels -
John Zuhone -
John ZuHone
-
Matthew Turk -
Michael Zingale