Hi all,
I would very much appreciate it if we could get some eyes on the following pull requests:
Add a cookbook recipe for a multipanel phase plot: https://github.com/yt-project/yt/pull/1605
Make covering_grid work with yt's parallelism: https://github.com/yt-project/yt/pull/1612
Automatically set up particle filter dependencies: https://github.com/yt-project/yt/pull/1624
Improvements for the WarpX frontend: https://github.com/yt-project/yt/pull/1634
Improvements for the quiver callback: https://github.com/yt-project/yt/pull/1636
Use python_requires in yt's setup.py: https://github.com/yt-project/yt/pull/1640
Fix bug related to dataset caching in the tests: https://github.com/yt-project/yt/pull/1643
All of these are passing the tests and are ready to merge in my opinion. However, I don't want us to get into a situation where only one person is regularly reviewing code. It would be really nice if one or two of you could go through this list and give all these pull requests a review. If you don't have time for that, just look over the ones that strike your interest.
Thanks very much for your help!
-Nathan
Thanks so much for taking a look!
Clearly getting emails about pull requests is quite effective in getting people’s attention. I’m going to look at setting up automatic email notifications to yt-dev for new pull requests.
Nathan
On Fri, Dec 8, 2017 at 11:49 AM Nathan Goldbaum nathan12343@gmail.com wrote:
Hi all,
I would very much appreciate it if we could get some eyes on the following pull requests:
Add a cookbook recipe for a multipanel phase plot: https://github.com/yt-project/yt/pull/1605
Make covering_grid work with yt's parallelism: https://github.com/yt-project/yt/pull/1612
Automatically set up particle filter dependencies: https://github.com/yt-project/yt/pull/1624
Improvements for the WarpX frontend: https://github.com/yt-project/yt/pull/1634
Improvements for the quiver callback: https://github.com/yt-project/yt/pull/1636
Use python_requires in yt's setup.py: https://github.com/yt-project/yt/pull/1640
Fix bug related to dataset caching in the tests: https://github.com/yt-project/yt/pull/1643
All of these are passing the tests and are ready to merge in my opinion. However, I don't want us to get into a situation where only one person is regularly reviewing code. It would be really nice if one or two of you could go through this list and give all these pull requests a review. If you don't have time for that, just look over the ones that strike your interest.
Thanks very much for your help!
-Nathan