VR refactor status update
Hi all, Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started. Where we're at: * Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :) Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate. -Matt
Hi Matt, Sure! I will have my PhD candidate advancement exam this afternoon and a last final tomorrow, then I can work this out as soon as possible! Best wishes, Suoqing
On Jun 2, 2015，11:18 AM，Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hi Suoqing, Um, take your time. :-) -Matt PS Good luck / congrats! On Tue, Jun 2, 2015 at 1:40 PM, Suoqing JI <suoqing@physics.ucsb.edu> wrote:
Hi Matt,
Sure! I will have my PhD candidate advancement exam this afternoon and a last final tomorrow, then I can work this out as soon as possible!
Best wishes, Suoqing
On Jun 2, 2015，11:18 AM，Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Hi Matt, I'd be interested in helping work on the VR stuff too since I've been involved in this effort (writing the YTEP, helping Sam with some of the code and layout). Next time you guys have a hangout on this, would you let me know? Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene class more inclusive of TimeSeries data before the 3.2 release goes out. Cameron On Tue, Jun 2, 2015 at 11:18 AM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
Hi Cameron, On Tue, Jun 2, 2015 at 1:48 PM, Cameron Hummels <chummels@gmail.com> wrote:
Hi Matt,
I'd be interested in helping work on the VR stuff too since I've been involved in this effort (writing the YTEP, helping Sam with some of the code and layout). Next time you guys have a hangout on this, would you let me know?
Yes -- I posted about it in the slack channel. Sorry I didn't send it to the list. Do you want to help with documentation, or with porting the remaining cameras?
Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene class more inclusive of TimeSeries data before the 3.2 release goes out.
Please go ahead and do that!
Cameron
On Tue, Jun 2, 2015 at 11:18 AM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Yes -- I posted about it in the slack channel. Sorry I didn't send it to the list.
Yeah, I've been slacking on checking on slack, as I'm on an review panel
later this week that's eating up all my time.
Do you want to help with documentation, or with porting the remaining cameras?
I'm up for helping with stuff, but my contributions will have to wait until the weekend after this panel. If you want to jump into docs, I can review and extend based on your first pass?
Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene class more inclusive of TimeSeries data before the 3.2 release goes out.
Please go ahead and do that!
OK, awesome. I'll check in with people on the mailing list and slack after I've made some progress early next week.
Cameron
--
Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
Hi Cameron, On Tue, Jun 2, 2015 at 1:54 PM, Cameron Hummels <chummels@gmail.com> wrote:
Yes -- I posted about it in the slack channel. Sorry I didn't send it to the list.
Yeah, I've been slacking on checking on slack, as I'm on an review panel later this week that's eating up all my time.
OK -- well, the hangout was very short anyway, and we concluded that documentation was the big thing left.
Do you want to help with documentation, or with porting the remaining cameras?
I'm up for helping with stuff, but my contributions will have to wait until the weekend after this panel. If you want to jump into docs, I can review and extend based on your first pass?
Sure. I was planning on doing them all by myself anyway, so any help you can provide would be great. Because the backwards compatible layer is already in, and a good amount of other work is now blocked on this PR, I'm hoping to finish it off right away. As a sidenote, in July a planetarium show is coming out that used the scene refactor for some of its rendering. So I think the code might be solid at this point. -Matt
Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene class more inclusive of TimeSeries data before the 3.2 release goes out.
Please go ahead and do that!
OK, awesome. I'll check in with people on the mailing list and slack after I've made some progress early next week.
Cameron
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Oh I'm not suggesting that the code isn't solid, just that one of the main points in doing the refactor was to make the scene stuff more general and able to work with TimeSeries data instead of individual frames one-at-a-time. I'd just as soon get that into the codebase before it gets released so any api changes are done up front before the api becomes more permanent. What other work is blocked on this PR? On Tue, Jun 2, 2015 at 12:05 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi Cameron,
On Tue, Jun 2, 2015 at 1:54 PM, Cameron Hummels <chummels@gmail.com> wrote:
Yes -- I posted about it in the slack channel. Sorry I didn't send it to the list.
Yeah, I've been slacking on checking on slack, as I'm on an review panel later this week that's eating up all my time.
OK -- well, the hangout was very short anyway, and we concluded that documentation was the big thing left.
Do you want to help with documentation, or with porting the remaining cameras?
I'm up for helping with stuff, but my contributions will have to wait
until
the weekend after this panel. If you want to jump into docs, I can review and extend based on your first pass?
Sure. I was planning on doing them all by myself anyway, so any help you can provide would be great. Because the backwards compatible layer is already in, and a good amount of other work is now blocked on this PR, I'm hoping to finish it off right away.
As a sidenote, in July a planetarium show is coming out that used the scene refactor for some of its rendering. So I think the code might be solid at this point.
-Matt
Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene class more inclusive of TimeSeries data before the 3.2 release goes out.
Please go ahead and do that!
OK, awesome. I'll check in with people on the mailing list and slack
after
I've made some progress early next week.
Cameron
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
On Tue, Jun 2, 2015 at 2:25 PM, Cameron Hummels <chummels@gmail.com> wrote:
Oh I'm not suggesting that the code isn't solid, just that one of the main points in doing the refactor was to make the scene stuff more general and able to work with TimeSeries data instead of individual frames one-at-a-time. I'd just as soon get that into the codebase before it gets released so any api changes are done up front before the api becomes more permanent.
When do you think you might be able to work on that?
What other work is blocked on this PR?
Unstructured mesh relies on it, as does the OpenGL volume rendering.
On Tue, Jun 2, 2015 at 12:05 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi Cameron,
On Tue, Jun 2, 2015 at 1:54 PM, Cameron Hummels <chummels@gmail.com> wrote:
Yes -- I posted about it in the slack channel. Sorry I didn't send it to the list.
Yeah, I've been slacking on checking on slack, as I'm on an review panel later this week that's eating up all my time.
OK -- well, the hangout was very short anyway, and we concluded that documentation was the big thing left.
Do you want to help with documentation, or with porting the remaining cameras?
I'm up for helping with stuff, but my contributions will have to wait until the weekend after this panel. If you want to jump into docs, I can review and extend based on your first pass?
Sure. I was planning on doing them all by myself anyway, so any help you can provide would be great. Because the backwards compatible layer is already in, and a good amount of other work is now blocked on this PR, I'm hoping to finish it off right away.
As a sidenote, in July a planetarium show is coming out that used the scene refactor for some of its rendering. So I think the code might be solid at this point.
-Matt
Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene class more inclusive of TimeSeries data before the 3.2 release goes out.
Please go ahead and do that!
OK, awesome. I'll check in with people on the mailing list and slack after I've made some progress early next week.
Cameron
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
On Tue, Jun 2, 2015 at 12:26 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Oh I'm not suggesting that the code isn't solid, just that one of the
On Tue, Jun 2, 2015 at 2:25 PM, Cameron Hummels <chummels@gmail.com> wrote: main
points in doing the refactor was to make the scene stuff more general and able to work with TimeSeries data instead of individual frames one-at-a-time. I'd just as soon get that into the codebase before it gets released so any api changes are done up front before the api becomes more permanent.
When do you think you might be able to work on that?
As I mentioned a couple of messages ago, I'm game to work on this early next week. This review panel is eating all my time right now.
What other work is blocked on this PR?
Unstructured mesh relies on it, as does the OpenGL volume rendering.
On Tue, Jun 2, 2015 at 12:05 PM, Matthew Turk <matthewturk@gmail.com>
Hi Cameron,
On Tue, Jun 2, 2015 at 1:54 PM, Cameron Hummels <chummels@gmail.com> wrote:
Yes -- I posted about it in the slack channel. Sorry I didn't send
it
to the list.
Yeah, I've been slacking on checking on slack, as I'm on an review
wrote: panel
later this week that's eating up all my time.
OK -- well, the hangout was very short anyway, and we concluded that documentation was the big thing left.
Do you want to help with documentation, or with porting the remaining cameras?
I'm up for helping with stuff, but my contributions will have to wait until the weekend after this panel. If you want to jump into docs, I can review and extend based on your first pass?
Sure. I was planning on doing them all by myself anyway, so any help you can provide would be great. Because the backwards compatible layer is already in, and a good amount of other work is now blocked on this PR, I'm hoping to finish it off right away.
As a sidenote, in July a planetarium show is coming out that used the scene refactor for some of its rendering. So I think the code might be solid at this point.
-Matt
Also, the VR refactor was originally meant to address TimeSeries so movies were more easily made (movie paths, etc.). As the VR code gets merged into the mainline, I'd love to work with people on making the Scene
class
more inclusive of TimeSeries data before the 3.2 release goes out.
Please go ahead and do that!
OK, awesome. I'll check in with people on the mailing list and slack after I've made some progress early next week.
Cameron
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Cameron Hummels Postdoctoral Researcher Steward Observatory University of Arizona http://chummels.org
Hi everyone, Returning to this thread a week later. Suoqing has updated a few of the cameras, and I've written a bunch of documentation. A few of us have also tested out some of the new capabilities, and while they aren't without some flaws, I think they're pretty darn solid at this point. I broke one of Suoqing's open PRs to Sam's repo, which I intend to fix, but I think that at least from a documentation perspective this PR is ready to review: https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-... Comments on documentation would be extremely appreciated. Thanks, Matt On Tue, Jun 2, 2015 at 1:18 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt
On 06/09/2015 01:40 PM, Matthew Turk wrote:
Hi everyone,
Returning to this thread a week later. Suoqing has updated a few of the cameras, and I've written a bunch of documentation. A few of us have also tested out some of the new capabilities, and while they aren't without some flaws, I think they're pretty darn solid at this point. I broke one of Suoqing's open PRs to Sam's repo, which I intend to fix, but I think that at least from a documentation perspective this PR is ready to review:
https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-...
Comments on documentation would be extremely appreciated.
Hi, FTR pre-built docs are available at: http://hub.yt:8080/job/yt_docs/50/artifact/sandbox/doc/build/html/index.html There's also a neat, 360deg movie based on Nathan's simulation, that Matt made using new VR framework: https://youtu.be/T9kRtgHFG9I Cheers, Kacper
Thanks,
Matt
On Tue, Jun 2, 2015 at 1:18 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Here's the script! http://paste.yt-project.org/show/5623/ I'm hoping to make it into a cookbook recipe. On Wed, Jun 10, 2015 at 3:19 PM, Kacper Kowalik <xarthisius.kk@gmail.com> wrote:
On 06/09/2015 01:40 PM, Matthew Turk wrote:
Hi everyone,
Returning to this thread a week later. Suoqing has updated a few of the cameras, and I've written a bunch of documentation. A few of us have also tested out some of the new capabilities, and while they aren't without some flaws, I think they're pretty darn solid at this point. I broke one of Suoqing's open PRs to Sam's repo, which I intend to fix, but I think that at least from a documentation perspective this PR is ready to review:
https://bitbucket.org/yt_analysis/yt/pull-request/1256/wip-volume-rendering-...
Comments on documentation would be extremely appreciated.
Hi, FTR pre-built docs are available at:
http://hub.yt:8080/job/yt_docs/50/artifact/sandbox/doc/build/html/index.html
There's also a neat, 360deg movie based on Nathan's simulation, that Matt made using new VR framework:
Cheers, Kacper
Thanks,
Matt
On Tue, Jun 2, 2015 at 1:18 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Andrew, Kacper, Allyson and I had a hangout to go over the current state of the VR refactor that Sam started.
Where we're at:
* Docs need to be written and updated. I have committed to taking this on, and I am starting today. * There are two cameras that need to be ported, the setreo spherical camera and the perspective camera. Suoqing, is there any chance you might be able to take a look at doing this, and issuing a PR to Sam's repository? I ask only because you've been so good at camera porting in the past. :)
Once that's done, since there is a backwards-compatible camera interface, I assert that we should consider heavily simply pulling in the code and beginning to migrate.
-Matt
yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (4)
-
Cameron Hummels -
Kacper Kowalik -
Matthew Turk -
Suoqing JI