Hi folks,
In this weeks "PyCoders" newsletter, they note that "git blame" can now ignore revisions.
https://twitter.com/llanga/status/1163767833706323970 https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs...
I believe this might remove one of the biggest objections we've had to things like running a code formatter such as black. It's not obvious to me that there won't be additional issues introduced by doing this, but it could be a good starting place for consistent code formatting.
-Matt
Hi Matt,
I think it's worth giving this a shot. Does anyone know of any bots or other automated ways of applying this to pull requests?
Britton
On Tue, Aug 20, 2019 at 8:37 PM Matthew Turk matthewturk@gmail.com wrote:
Hi folks,
In this weeks "PyCoders" newsletter, they note that "git blame" can now ignore revisions.
https://twitter.com/llanga/status/1163767833706323970
https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs...
I believe this might remove one of the biggest objections we've had to things like running a code formatter such as black. It's not obvious to me that there won't be additional issues introduced by doing this, but it could be a good starting place for consistent code formatting.
-Matt _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
For unyt I just have a test in the test suite that checks to make sure if black has output and if it does, it fails the test:
https://github.com/yt-project/unyt/blob/41bf39cbc73e85468d2aea780b5a88ae218e...
There is also this:
https://github.com/Mariatta/black_out
On Tue, Aug 27, 2019 at 4:16 AM Britton Smith brittonsmith@gmail.com wrote:
Hi Matt,
I think it's worth giving this a shot. Does anyone know of any bots or other automated ways of applying this to pull requests?
Britton
On Tue, Aug 20, 2019 at 8:37 PM Matthew Turk matthewturk@gmail.com wrote:
Hi folks,
In this weeks "PyCoders" newsletter, they note that "git blame" can now ignore revisions.
https://twitter.com/llanga/status/1163767833706323970
https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs...
I believe this might remove one of the biggest objections we've had to things like running a code formatter such as black. It's not obvious to me that there won't be additional issues introduced by doing this, but it could be a good starting place for consistent code formatting.
-Matt _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
Hi Britton, I've seen a lot of projects using "pre-commit" [1] You basically pip install it, add a config yaml file [2] and forget about the whole thing ;-) Cheers, Kacper
[1] https://pre-commit.com/ [2] https://raw.githubusercontent.com/jupyter/repo2docker/master/.pre-commit-con...
On 8/27/19 4:16 AM, Britton Smith wrote:
Hi Matt,
I think it's worth giving this a shot. Does anyone know of any bots or other automated ways of applying this to pull requests?
Britton
On Tue, Aug 20, 2019 at 8:37 PM Matthew Turk <matthewturk@gmail.com mailto:matthewturk@gmail.com> wrote:
Hi folks, In this weeks "PyCoders" newsletter, they note that "git blame" can now ignore revisions. https://twitter.com/llanga/status/1163767833706323970 https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt I believe this might remove one of the biggest objections we've had to things like running a code formatter such as black. It's not obvious to me that there won't be additional issues introduced by doing this, but it could be a good starting place for consistent code formatting. -Matt _______________________________________________ yt-dev mailing list -- yt-dev@python.org <mailto:yt-dev@python.org> To unsubscribe send an email to yt-dev-leave@python.org <mailto:yt-dev-leave@python.org>
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
Hi folks,
OK, so there's sorta of medium support for it! I've been experimenting with the various things and I *think* this could work.
Still, we'd need to basically do a flag day on the code, *or* go through and manually reformat all the code out there in extant pull requests.
Should we discuss at an upcoming team meeting, but with the tentative plan to evaluate it as a go?
On Tue, Aug 27, 2019 at 8:36 AM Kacper Kowalik xarthisius.kk@gmail.com wrote:
Hi Britton, I've seen a lot of projects using "pre-commit" [1] You basically pip install it, add a config yaml file [2] and forget about the whole thing ;-) Cheers, Kacper
[1] https://pre-commit.com/ [2] https://raw.githubusercontent.com/jupyter/repo2docker/master/.pre-commit-con...
On 8/27/19 4:16 AM, Britton Smith wrote:
Hi Matt,
I think it's worth giving this a shot. Does anyone know of any bots or other automated ways of applying this to pull requests?
Britton
On Tue, Aug 20, 2019 at 8:37 PM Matthew Turk <matthewturk@gmail.com mailto:matthewturk@gmail.com> wrote:
Hi folks, In this weeks "PyCoders" newsletter, they note that "git blame" can now ignore revisions. https://twitter.com/llanga/status/1163767833706323970 https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt I believe this might remove one of the biggest objections we've had to things like running a code formatter such as black. It's not obvious to me that there won't be additional issues introduced by doing this, but it could be a good starting place for consistent code formatting. -Matt _______________________________________________ yt-dev mailing list -- yt-dev@python.org <mailto:yt-dev@python.org> To unsubscribe send an email to yt-dev-leave@python.org <mailto:yt-dev-leave@python.org>
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-
Britton Smith -
Kacper Kowalik -
Matthew Turk -
Nathan