Typing: request for second set of eyes

Hi folks,
Can somebody (other than me) take a look at this?
https://github.com/yt-project/yt/pull/3546
I think it should be fine to go in, and I don't want to let it linger too long.
-Matt

Thank you guys for merging this !
Now we have a static type checker (mypy) running on every PR, meaning we should be able to add type annotations with good levels of stability.
I would like to emphasize that mypy’s scope is a bit larger than just checking type annotations (it has small overlaps with flake8, for instance), and the errors it finds may be a little confusing at times. Please do not hesitate to ping me in the future if you need any help in your PRs to satisfy mypy. Also note that mypy is not integrated in our pre-commit toolbelt yet.
Happy development everyone ! Clément
On Wed, Nov 24, 2021 at 18:14, Corentin Cadiou cadiou@iap.fr wrote:
Done! _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: clement.robert@protonmail.com
participants (3)
-
Clément Robert
-
Corentin Cadiou
-
Matthew Turk