code review request: data file initialization
Hi all, Could I get one or two people to look this over, and give me the thumbs up? I applied a hotfix to the repo yesterday because of problems during the Enzo Workshop. It was trying to create the .yt file for every user, even though they didn't have write privs -- this was because of an indentation error, but then I committed one that was *also* not great (but worked to fix the workshop issues) and I have, I think, settled upon one that works, that explores the four conditionals (noted in the patch.) http://paste.enzotools.org/show/857/ If I get a thumbs up, I'll commit. -Matt
Thumbs up! _______________________________________________________ sskory@physics.ucsd.edu o__ Stephen Skory http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student ________________________________(_)_\(_)_______________ ----- Original Message ----
From: Matthew Turk <matthewturk@gmail.com> To: yt-dev@lists.spacepope.org Sent: Tue, June 29, 2010 10:01:44 AM Subject: [Yt-dev] code review request: data file initialization
Hi all,
the
of
.yt file for every user, even though they didn't have write privs -- this was because of an indentation error, but then I committed one that was *also* not great (but worked to fix the workshop issues) and I have, I
Could I get one or two people to look this over, and give me thumbs up? I applied a hotfix to the repo yesterday because problems during the Enzo Workshop. It was trying to create the think, settled upon one that works, that explores the four conditionals
(noted in the patch.)
http://paste.enzotools.org/show/857/ If I
get a thumbs up, I'll commit.
-Matt _______________________________________________ Yt-dev
mailing list
href="mailto:Yt-dev@lists.spacepope.org">Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
One question: writeable = writeable and ytcfg.getboolean('lagos','onlydeserialize') should this be writable and NOT ytcfg.getboolean('lagos','onlydeserialize')? As I read it, if onlydeserialize is True, then we Don't want to write, right? I assume here that deserialize means to *read* not to *write*, but I'm not sure. j On Tue, Jun 29, 2010 at 10:03 AM, Stephen Skory <stephenskory@yahoo.com> wrote:
Thumbs up! _______________________________________________________ sskory@physics.ucsd.edu o__ Stephen Skory http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student ________________________________(_)_\(_)_______________
----- Original Message ----
From: Matthew Turk <matthewturk@gmail.com> To: yt-dev@lists.spacepope.org Sent: Tue, June 29, 2010 10:01:44 AM Subject: [Yt-dev] code review request: data file initialization
Hi all,
the
of
.yt file for every user, even though they didn't have write privs -- this was because of an indentation error, but then I committed one that was *also* not great (but worked to fix the workshop issues) and I have, I
Could I get one or two people to look this over, and give me thumbs up? I applied a hotfix to the repo yesterday because problems during the Enzo Workshop. It was trying to create the think, settled upon one that works, that explores the four conditionals
(noted in the patch.)
http://paste.enzotools.org/show/857/
If I
get a thumbs up, I'll commit.
-Matt _______________________________________________ Yt-dev
mailing list
href="mailto:Yt-dev@lists.spacepope.org">Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Yt-dev mailing list Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- ---------------- i am dot org: www.jsoishi.org
You're right, it should be "and not". Thanks, Jeff and Stephen! I'll commit now. On Tue, Jun 29, 2010 at 10:08 AM, j s oishi <jsoishi@gmail.com> wrote:
One question:
writeable = writeable and ytcfg.getboolean('lagos','onlydeserialize')
should this be writable and NOT ytcfg.getboolean('lagos','onlydeserialize')? As I read it, if onlydeserialize is True, then we Don't want to write, right? I assume here that deserialize means to *read* not to *write*, but I'm not sure.
j
On Tue, Jun 29, 2010 at 10:03 AM, Stephen Skory <stephenskory@yahoo.com> wrote:
Thumbs up! _______________________________________________________ sskory@physics.ucsd.edu o__ Stephen Skory http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student ________________________________(_)_\(_)_______________
----- Original Message ----
From: Matthew Turk <matthewturk@gmail.com> To: yt-dev@lists.spacepope.org Sent: Tue, June 29, 2010 10:01:44 AM Subject: [Yt-dev] code review request: data file initialization
Hi all,
the
of
.yt file for every user, even though they didn't have write privs -- this was because of an indentation error, but then I committed one that was *also* not great (but worked to fix the workshop issues) and I have, I
Could I get one or two people to look this over, and give me thumbs up? I applied a hotfix to the repo yesterday because problems during the Enzo Workshop. It was trying to create the think, settled upon one that works, that explores the four conditionals
(noted in the patch.)
http://paste.enzotools.org/show/857/
If I
get a thumbs up, I'll commit.
-Matt _______________________________________________ Yt-dev
mailing list
href="mailto:Yt-dev@lists.spacepope.org">Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
Yt-dev mailing list Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- ---------------- i am dot org: www.jsoishi.org _______________________________________________ Yt-dev mailing list Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (3)
-
j s oishi -
Matthew Turk -
Stephen Skory