Hi all, can I get an up/down/suggestions vote on pull request 34? It's just one line, it's been there for three days, and I think it's useful. The only thing I might see as a better alternative is for Clump to inherit from AMR3DData, but that is a bigger change, and not necessarily better. Thanks! https://bitbucket.org/yt_analysis/yt/pull-request/34/quantities-for-clumps -- Stephen Skory s@skory.us http://stephenskory.com/ 510.621.3687 (google voice)
Hi Stephen, This looks ok to me, but I'm not really an expert on clumps, by which I mean I've never even used one. Maybe someone with more experience can chime in? kj On Fri, Nov 18, 2011 at 12:52 PM, Stephen Skory <s@skory.us> wrote:
Hi all,
can I get an up/down/suggestions vote on pull request 34? It's just one line, it's been there for three days, and I think it's useful. The only thing I might see as a better alternative is for Clump to inherit from AMR3DData, but that is a bigger change, and not necessarily better. Thanks!
https://bitbucket.org/yt_analysis/yt/pull-request/34/quantities-for-clumps
-- Stephen Skory s@skory.us http://stephenskory.com/ 510.621.3687 (google voice) _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
I think you should stick a line in _reconstruct_clump, after obj.data = (blah), obj.quantities = obj.data.quantities. I like myself some pickles, this will ensure that when you unpickle you'll get the same object. (I'm pretty sure-- try pickling one to disk, unpickling, and checking the behavior.) d. On Fri, Nov 18, 2011 at 3:38 PM, j s oishi <jsoishi@gmail.com> wrote:
Hi Stephen,
This looks ok to me, but I'm not really an expert on clumps, by which I mean I've never even used one. Maybe someone with more experience can chime in?
kj
On Fri, Nov 18, 2011 at 12:52 PM, Stephen Skory <s@skory.us> wrote:
Hi all,
can I get an up/down/suggestions vote on pull request 34? It's just one line, it's been there for three days, and I think it's useful. The only thing I might see as a better alternative is for Clump to inherit from AMR3DData, but that is a bigger change, and not necessarily better. Thanks!
https://bitbucket.org/yt_analysis/yt/pull-request/34/quantities-for-clumps
-- Stephen Skory s@skory.us http://stephenskory.com/ 510.621.3687 (google voice) _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
-- Sent from my computer.
Dave,
I think you should stick a line in _reconstruct_clump, after obj.data = (blah), obj.quantities = obj.data.quantities.
Thanks for the suggestion! I've made the change. -- Stephen Skory s@skory.us http://stephenskory.com/ 510.621.3687 (google voice)
participants (3)
-
david collins -
j s oishi -
Stephen Skory