It should be changed. In theory, they'll usually be the same in most cases, but it is a typo and it's fixed.
(Also, the treecode was all Stephen Skory -- I agree with your sentiment, it's a huge benefit, and I'm very appreciative of it too!)
On Fri, May 27, 2011 at 10:16 AM, Andrew Davis firstname.lastname@example.org wrote:
I just updated my yt yesterday to use the new treecode algorithm in calculating binding energies. Many many thanks to those who worked on it and tested it. However, I'm looking at the code, and I see this in the function (on line 388 of derived_quantities.py):
octree = Octree(cover_ActiveDimensions, 1, True) #print 'here', cover_ActiveDimensions # Now discover what levels this data comes from, not assuming # symmetry. dxes = na.unique(data['dx']) # unique returns a sorted array, dyes = na.unique(data['dy']) # so these will all have the same --->>>> dzes = na.unique(data['dx']) # order. # We only need one dim to figure out levels, we'll use x. dx = 1./data.pf.domain_dimensions
I've marked the line where I would think it should be getting data['dz'] instead of 'dx'. Am I just not getting this or should this be changed?
** Andrew J. Davis email@example.com ** ** Dept. of Astronomy 203-432-5119 ** ** Yale University www.astro.yale.edu/adavis **
yt-users mailing list firstname.lastname@example.org http://lists.spacepope.org/listinfo.cgi/yt-users-spacepope.org