Yeah, I think I'll take you up on your offer to issue the PR.
On Tue, Mar 8, 2016 at 3:45 PM, email@example.com wrote:
Date: Tue, 8 Mar 2016 14:41:42 -0600 From: Matthew Turk firstname.lastname@example.org To: Discussion of the yt analysis package email@example.com Subject: Re: [yt-users] found the problem with non-square frb Message-ID: <CALO3=5G0vR-=7G+KaQZo= Z5-7VoHngFZJvmbduensONdMcHbpQ@mail.gmail.com> Content-Type: text/plain; charset=UTF-8
That would be an awesome pull request, but I understand your reluctance. I'm happy to issue it for you and credit you in the PR. :)
On Tue, Mar 8, 2016 at 2:39 PM, Slavin, Jonathan firstname.lastname@example.org wrote:
I just located the problem referred to in my earlier message. There's a very small bug in data_objects/data_containers.py On lines 957 - 959 there is: elif iterable(height): h, u = height height = self.ds.quan(w, input_units = u) Note the w in self.ds_quan(w, input_units = u). Just replace that w
h and it works. Should I file a pull request? Seems a bit much for
minor bug, but I'm willing to do it.