[AstroPy] PR 3655 (Fortran-style and large exponents in ascii.io)

Evert Rol evert.rol at gmail.com
Mon Jul 11 20:36:22 EDT 2016


> is there anyone else I should send this to regarding the PR?

Probably not.
There is the astropy developer mailing list, which is separate to this mailing list(*), but if you've updated the PR, the astropy maintainers should get informed automatically.
Best I can advice, is to keep your PR up-to-date with the current master, verify all tests still pass on Github, and wait (or possibly ping people on GitHub through a comment).
The PR will need someone to review it, and a knowledgeable reviewer may not have found time yet to do that.

  Evert

(*) this mailing list is more for general help with Python in an astronomical context. Perhaps you had meant to send this email to the astropy developer mailing list the first time?


>> first, this is an invitation to review the pull request for Fortran-style exponent character support
>> 
>> https://github.com/astropy/astropy/pull/3655
>> 
>> which has been dormant for a fairly long time because of some test crashes on travis.
>> I’ve noticed far too late that long exponents (> 3 digits) already were flagged as a known
>> cause of segfaults on travis, and therefore have now isolated the corresponding tests
>> and marked them xfail.
>> Second, in the comments on that PR some existing inconsistencies between the handling
>> of ‘illegal’ exponents had been discussed; see my last comment for a kind of summary.
>> Summary of the summary, strings with exponents exceeding float64 range are e.g. read
>> in as inf and 0.0 in plain Python [float('1.423e388’)], while the ascii.io standard has generally
>> asked to return such entries as string fields. Numpy OTOH can parse such numbers as
>> extended precision if specifically asked:
>> 
>> np.float128('1.423e388')*10
>> 1.423e+389
>> 
>> So I’d also like to poll if there is general interest in having ascii.io be able to handle such
>> numbers as well (set by an option, if necessary), which might then include four-digit
>> exponents.
>> 
> Thanks,
> 					Derek
> 
> _______________________________________________
> AstroPy mailing list
> AstroPy at scipy.org
> https://mail.scipy.org/mailman/listinfo/astropy




More information about the AstroPy mailing list