[Borgbackup] bundling msgpack for borgback distribution

[Sitaram Chamarty]

On 06/05/2019 21.34, Felix Schwarz wrote:
> Hi,
> 
> how comprehensive is borgbackup's test suite when it comes to msgpack?
> If the test suite does not report any errors may I assume that the used
> version of msgpack is likely working correctly?
> 
> Background:
> Unfortunately Fedora 30 ships msgpack 0.6.1 but there is no released version
> of borgbackup which can handle this version of msgpack.
> 
> I'm looking for stop-gap measures to get borgbackup running in Fedora 30 again
> (must be able to distribute this via Fedora's package manager so no local
> one-off builds).
> 
> I assume the simplest way to achieve this is to bundle msgpack 0.5.6 into
> borgbackup for distribution. During packaging we run borg's test suite.
> Assuming the test suite passes may I assume that borg will be fine-ish?
> 
> (I know that is a hack and I don't like doing that to such an important
> package like borg. But on the other hand borg is unusable on Fedora 30 right
> now. The only thing which could be worse is if borg starts eating the users
> backup data.)

Are you the Fedora package maintainer for this tool?

If so, you probably know that this has happened once in the past --
though I cannot quite recall exactly when.  Anyway, I definitely got a
sense of deja vu seeing those errors, as well as seeing the patch at
https://github.com/borgbackup/borg/commit/0ebfaa5b61a675c22cda301bc20d0b00372dd181

I'm just mentioning it because you said "looking for stop-gap measures".
 Maybe it's better to think about bundling msgpack with borg as a matter
of routine; i.e., ignore whatever msgpack is installed in the system and
use its own, on a regular basis.

(My current solution is to downgrade msgpack, since I found nothing else
was using it; credit to
https://bugzilla.redhat.com/show_bug.cgi?id=1669083#c11 for this)