[CentralOH] Python Puzzle: Day generator

[iynaix]

Use isinstance(x, basestring) instead of isinstance(x, str) for python 2.x
as basestring handles both 'str' and 'unicode' string types in python 2.x.

This is not needed in python 3.x since all strings are now unicode and
there is only one 'str' to rule them all.

More detailed explanation and example here:

http://stackoverflow.com/a/1979107

Cheers,
XY

On Thu, Feb 5, 2015 at 3:06 PM, <jep200404 at columbus.rr.com> wrote:

> On Wed, 4 Feb 2015 20:55:14 -0500, Eric Floehr <eric at intellovations.com>
> wrote:
>
> > Here is a group puzzle. I am interested in everyone's solutions.
>
> > ... I need to iterate through days.
> > So I thought to make a function that works like range() only with dates.
>
> See http://colug.net/python/cohpy/20150205/
> for what I did before looking at your code.
>
> > And my solution (open to refactoring):
> > https://gist.github.com/efloehr/3e1dd639f3c5c1b064b7
>
> Here's some refactoring comments, and comparison to my code,
> particularly of my cell #5.
>
> First, some easy PEP 8 stuff:
>
>     Use isinstance() instead of type() == str
>     Delete the spaces inside the [] of your comprehensions
>
> I like day= in timedelta(day=1) in your code. It documents the value.
> Likewise for days= at the bottom.
>
> .strptime() in my code makes short work of parsing YYYY-MM-DD strings.
> Your start_day is None is more correct than my not start_date.
>
> Because of your range test, I see that your loop only goes once
> for bad step polarities, instead of the infinite loop I feared.
> It would be good to tighten up the specification for what
> behavior is desired for whacko step polarity. Does the
> polarity handling in your day_generator() make your other
> code do nothing gracefully?
>
> The names range_start and range_end are misleading.
> Better names would be range_min and range_max.
>
> Looking at your min()/max() lines, I wish there were a minmax()
> function that returned a tuple, kind of like divmod() does for
> division.
>
> Can your while loop be simplified to the following?
>
>     while range_min <= current_day <= range_max:
>
> I like the way that testing against both the min and max,
> avoids the need to figure out which single test would suffice.
>
> Doing from datetime import in your code made your other code
> easier to read than mine.
>
> Even though my having d and start_date refer to the same object
> causes no bug, your current_day = copy(start_day) is more prudent
> than my d = start_date. Of course, I could just claim that d
> is a pronoun for start_date. :-)
>
> Your day_step is a better argument name than my terse step,
> because yours documents the value better.
>
> I'm a little surprised I did not take advantage of elif for
> my isinstance() code.
>
> What else did I miss?
> _______________________________________________
> CentralOH mailing list
> CentralOH at python.org
> https://mail.python.org/mailman/listinfo/centraloh
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/centraloh/attachments/20150205/02da5963/attachment.html>