[code-quality] Is it necessary to use python 3.x for patching something (and running tests) in pylint code-base?

[Florian Bruhin]

Hey,

(I Cc'ed the list again, as others might be able to help as well)

* Ahirnish Pareek <ahirnish at arista.com> [2016-04-20 16:20:42 +0530]:
> I tried your suggestion by installing and running tests with tox but I ran
> into some errors. Would you mind giving me pointers to fix them?
> 
> 1. ERROR: InvocationError:
> '/Users/ahirnish/pylint_patch/pylint/.tox/py27/bin/python -Wi -m unittest
> discover -s
> /Users/ahirnish/pylint_patch/pylint/.tox/py27/lib/python2.7/site-packages/pylint/test/
> -p *test_*.py'
> 
> Not able to figure out what InvocationError means?

It simply means the things you asked tox to run did fail (i.e. exit
with a nonzero status). The output above that should tell you why that
happened.

> 2.  During running of /test/test_func.py, I got this -
> File
> "/Users/ahirnish/pylint_patch/pylint/.tox/py27/lib/python2.7/site-packages/pylint/test/test_func.py",
> line 33, in <module>
>     INPUT_DIR = join(dirname(abspath(__file__)), 'input')
> NameError: name 'join' is not defined
> 
> After grepping for 'join', I found that its defined in astroid folder. Do i
> need to run tox in asteroid folder too? Is there anything extra I need to
> do install/setup from asteroid folder in order to run tox in pylint
> successfuly?

I'm not sure how you came to that conclusion - the file simply does
"from os.path import join":

https://github.com/PyCQA/pylint/blob/master/pylint/test/test_func.py#L23

So if you didn't accidentally remove that import line somehow, I can't
imagine how this would happen.

Florian

-- 
    http://www.the-compiler.org | me at the-compiler.org (Mail/XMPP)
       GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc
     I'm running a crowdfunding to work on my FOSS-project full-time:
                  http://igg.me/at/qutebrowser
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mail.python.org/pipermail/code-quality/attachments/20160420/0264f531/attachment.sig>