[core-workflow] Stage and keywords differences

[anatoly techtonik]

On Mon, Aug 4, 2014 at 1:45 AM, Ezio Melotti <ezio.melotti at gmail.com> wrote:
> On Sun, Aug 3, 2014 at 10:19 PM, francis <francismb at email.de> wrote:
>> Dear core-devs,
>> I would like to ask about the differences between (from the devguide [1]):
>> a) stage:needs patch and keywords:patch
>
> Stage can only be set by "Developers", the "patch" keyword can be
> added by anyone and it's added automatically when a file is attached
> to an issue.
>
>> b) stage:patch review and keywords:needs review
>>
>
> As above, but the "needs review" keyword is not added automatically.
>
>> Aren't those redundant? Why are those keywords needed?
>
> They are somewhat redundant, but the keywords allow regular users to
> signal that an issue needs review and/or has a patch.
> I don't know if this is the reason they were added in the first place,
> but removing them and make the stage settable by everyone would be
> fine with me.

+1 on above, except that patch keyword should stay.
stage:needs patch + keyword:patch can be switched automatically to
stage:needs review.

> Note that doing this will break a few things that look for the "patch"
> keyword, including the weekly report, the detector that sets the
> "patch" keyword, possibly the "issues with patch" query in the
> sidebar, a meta-tracker patch we made yesterday at the Helsinki
> sprint[0], and perhaps other tools.  Updating these things is not
> difficult though.

patch is not a stage, it is a property of the issue that is useful even
after stage is set to resolved.