From donald at stufft.io  Wed Sep 14 14:36:05 2016
From: donald at stufft.io (Donald Stufft)
Date: Wed, 14 Sep 2016 14:36:05 -0400
Subject: [core-workflow] GitHub New Feature
Message-ID: <6DB31414-6432-495D-9FEC-B5F9E5E4F3B9@stufft.io>

Looks Like GitHub is launching new features:

?Projects? - Allows you to make arbitrary columns and arrange your issues/PRs between them. I don?t directly see these as useful, however it could be nice for sprints or something. Overall I think this feature largely works best for projects using Github issues and not for us.

Code Reviews! - This provides a more traditional code review feature set for Pull Requests. When making a comment on a github Pull request you now have the option between ?Add a single comment? (what previously existed?) and ?Start a review?. This also allows people to submit all their comments at once as Just comments, or with an Approval or Disapproval of the PR as it exists. Approval/disapproval shows up like a CI status check and repositories can optionally have branches flagged as requiring review (which requires at least one approval, and no disapprovals).

They say they?re also working on additional follow up features, like explicit ability to request reviews from someone.

They also allow organizations to mandate 2Factor auth as well? This seems like it might be a good idea for us?

More Information: https://github.com/blog/2256-a-whole-new-github-universe-announcing-new-tools-forums-and-features

?
Donald Stufft




From ericsnowcurrently at gmail.com  Wed Sep 14 19:00:36 2016
From: ericsnowcurrently at gmail.com (Eric Snow)
Date: Wed, 14 Sep 2016 17:00:36 -0600
Subject: [core-workflow] GitHub New Feature
In-Reply-To: <6DB31414-6432-495D-9FEC-B5F9E5E4F3B9@stufft.io>
References: <6DB31414-6432-495D-9FEC-B5F9E5E4F3B9@stufft.io>
Message-ID: <CALFfu7DGMbGumTr53nbshFsA6pMrCq83K-7Yyn4WefFrc5Sf7A@mail.gmail.com>

On Wed, Sep 14, 2016 at 12:36 PM, Donald Stufft <donald at stufft.io> wrote:
> Code Reviews! - This provides a more traditional code review feature set for Pull Requests. When making a comment on a github Pull request you now have the option between ?Add a single comment? (what previously existed?) and ?Start a review?. This also allows people to submit all their comments at once as Just comments, or with an Approval or Disapproval of the PR as it exists. Approval/disapproval shows up like a CI status check and repositories can optionally have branches flagged as requiring review (which requires at least one approval, and no disapprovals).

The whole one-email-per-comment thing has been my main objection to
doing code review through GitHub.  So I'm glad that's been resolved.
There are plenty of other features I'd like (i.e. that ReviewBoard
gives you), but none of them are game changers.  Hey, I'm just glad I
don't have to avoid doing code reviews on GitHub now! :)

-eric

From ncoghlan at gmail.com  Wed Sep 14 23:14:40 2016
From: ncoghlan at gmail.com (Nick Coghlan)
Date: Thu, 15 Sep 2016 13:14:40 +1000
Subject: [core-workflow] GitHub New Feature
In-Reply-To: <6DB31414-6432-495D-9FEC-B5F9E5E4F3B9@stufft.io>
References: <6DB31414-6432-495D-9FEC-B5F9E5E4F3B9@stufft.io>
Message-ID: <CADiSq7fQKcZoQk+hbezkROPaYh-etvt0=MOYeNP_40QaQkf0rg@mail.gmail.com>

On 15 September 2016 at 04:36, Donald Stufft <donald at stufft.io> wrote:
> Looks Like GitHub is launching new features:
>
> ?Projects? - Allows you to make arbitrary columns and arrange your issues/PRs between them. I don?t directly see these as useful, however it could be nice for sprints or something. Overall I think this feature largely works best for projects using Github issues and not for us.

Right, it's fleshing out their capabilities to better compete with the
Atlassian suite of tools in a commercial context. Good for centrally
managed projects, less useful for looser collaborations. (although I
can see PyPA potentially getting more use out of it than CPython)

> Code Reviews! - This provides a more traditional code review feature set for Pull Requests. When making a comment on a github Pull request you now have the option between ?Add a single comment? (what previously existed?) and ?Start a review?. This also allows people to submit all their comments at once as Just comments, or with an Approval or Disapproval of the PR as it exists. Approval/disapproval shows up like a CI status check and repositories can optionally have branches flagged as requiring review (which requires at least one approval, and no disapprovals).
>
> They say they?re also working on additional follow up features, like explicit ability to request reviews from someone.

They seem to have taken the "Why do some folks prefer the way Gerrit
handles reviews?" question and realised that it isn't just folks being
unreasonable, but about those features actually being useful in
particular contexts :)

> They also allow organizations to mandate 2Factor auth as well? This seems like it might be a good idea for us?

Probably not as part of the initial migration (since we don't have 2FA
now), but we should definitely be planning to enable it after the
migration is done and folks have settled into the new workflows.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia