[core-workflow] Final chance to express opinion on history rewrite for issue #s

[Nick Coghlan]

On 9 February 2017 at 19:35, Brett Cannon <brett at python.org> wrote:
> On Thu, 9 Feb 2017 at 10:15 Nick Coghlan <ncoghlan at gmail.com> wrote:
>> That's actually the way hg.python.org injects the links now:
>> https://hg.python.org/cpython/rev/b07d454e45a2
>>
>> So +1 from me for appending the references to the old messages rather
>> than modifying them in place.
>
> What if we only did it for the beginning of the first line of the commit
> message and not the whole body? Senthil had a list in one of his emails of
> all the possible formats and if they were all anchored with "^" in the regex
> then the chance of a false-positive is essentially 0. That would give us the
> equivalent of what we have on hg.python.org but in-place and alleviates any
> worry of GitHub changing how they do things in the future (at least in terms
> of the line you see in log output).

Oh, nice idea.

+1 for that approach from me, since it gives the hyperlinkable version
even in the commit summary

> If people don't like that idea the appending works for me if it isn't
> difficult for Senthil.

but I'd still prefer this to not having the modified version at all.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia