[core-workflow] Final chance to express opinion on history rewrite for issue #s

Berker Peksağ berker.peksag at gmail.com
Fri Feb 10 00:41:18 EST 2017


On Fri, Feb 10, 2017 at 4:36 AM, Senthil Kumaran <senthil at uthcode.com> wrote:
> On Thu, Feb 9, 2017 at 4:28 PM, Ezio Melotti <ezio.melotti at gmail.com> wrote:
>> No need to wait, I put together a script that shows the result of the
>> rewriting :)
>
> Thank you, Ezio!
>
> I and Ezio were working on this today afternoon and agreed that if we
> do rewrite of various formats issue NNNN to bpo-NNNN then doing it
> over entire commit message gives much better experience than doing it
> over the first line.
>
>
> We can judge this by looking at the actual output (from the script
> that Ezio shared).
>
> http://orsenthil.github.io/cpython-hg-to-git/
>
> This picked up 1000 random revisions and added some tricky corner
> cases that we identified and did the re-write.
>
> Please view the output of commit logs converted here
> http://orsenthil.github.io/cpython-hg-to-git/ and see if it looks
> better than the status quo.

Thanks, Senthil and Ezio! Looks pretty good to me. I noticed some edge cases:

* -46692:46918 merged from branch aimacintyre-sf1454481
  +46692:46918 merged from branch aimacintyre-bpo-1454481

* -SF bug #1012315: weakref.WeakValueDictionary should override .has_key()
  +SF bpo-1012315:  weakref.WeakValueDictionary should override .has_key()

  -Backport checkin: Fix typo (from SF bug #1086127).
  +Backport checkin: Fix typo (from SF bpo-1086127).

  -   used on BTree databases.  [SF bug id 788421]
  +   used on BTree databases.  [SF bpo-788421]

  Is it possible to replace 'SF bug #NNNN' with 'bpo-NNNN'?

* -SF 798269:  bug fix for doctest (sf bug id: 798254
  +bpo-798269:  bug fix for doctest (sf bug id: 798254

  'bug id NNNN' matches but not 'bug id: NNNN'.

* -Resolves SF bugs 697989, 697988, 697986.
  +Resolves SF bpo-697989, 697988, 697986.

  This doesn't look like a common case and we can just ignore it :)

--Berker


More information about the core-workflow mailing list