[core-workflow] self-approving pull requests
Senthil Kumaran
senthil at uthcode.com
Wed Feb 22 11:35:35 EST 2017
On Wed, Feb 22, 2017 at 8:12 AM, Donald Stufft <donald at stufft.io> wrote:
> I’m happy to switch this around, but I don’t know whose call it is. Does
> Brett need to make this call? I dunno.
I am +1 on turning on the required status check before the merge is enabled.
It was briefly discussed here:
https://mail.python.org/pipermail/python-committers/2017-February/004255.html
We can use that thread to bring it to a closure.
I understand Nick's point of view in this thread. It might be that
given my time zone or chance, I could get reviewers easily. And, I
could pull myself to review small patches.
With our previous VCS, we have trusted core-developers to take
appropriate actions. So, for any significant changes, I assume,
developers will involve another developer for the review.
And for non-controversial, straightforward improvements, they would be
free to commit stuff (as it was the case with hg). Github allows such
a provision, if we decide to go for it, we should know that no
extra/special tooling should be required.
Thanks,
Senthil
More information about the core-workflow
mailing list