[core-workflow] Auto labeling PRs based on what stage they're in
Nick Coghlan
ncoghlan at gmail.com
Mon Jun 19 22:19:16 EDT 2017
On 20 June 2017 at 11:55, Brett Cannon <brett at python.org> wrote:
> On Mon, Jun 19, 2017, 18:15 Nick Coghlan, <ncoghlan at gmail.com> wrote:
>> "Awaiting changes" -> "Awaiting merge": Core dev implements changes
>
>
> They could change their review to handle this.
True.
>> Core dev PR -> "Awaiting changes"
>
> If this is due to a review from a core dev then it's just like any other
> core review as you don't want to ignore such a review.
True, but I was thinking of the "WIP" case - GitHub doesn't let you
review your own PRs, so you can't give yourself a negative review to
indicate that the PR is incomplete. However, setting "Awaiting
changes" explicitly will work fine.
Cheers,
Nick.
--
Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
More information about the core-workflow
mailing list