[C++-sig] Re: return_self_policy / return_arg
David Abrahams
dave at boost-consulting.com
Fri Jun 27 23:49:26 CEST 2003
Very nice. Just a couple nits:
Nikolay Mladenov <nickm at sitius.com> writes:
>>> from return_self import *
>>> l1=Label()
>>> l1 is l1.label("bar")
1
>>> l1 is l1.label("bar").sensitive(0)
1
>>> l1.label("foo").sensitive(0) is l1.sensitive(1).label("bar")
1
>>> return_arg is return_arg(return_arg)
1
These tests will break when we get bool in Python 2.3. I use assert
instead.
> namespace boost { namespace python
> {
> namespace detail
> {
> template <std::size_t>
> struct return_arg_policy_pos_argument_must_be_greater_than_zero
> # if defined(__GNUC__) && __GNUC__ >= 3 || defined(__EDG__)
> {error}
^^^^^
This will produce an error a little bit too early ;-)
I think you'd better delete it.
> # endif
> ;
>
Once these fixes have been made, anyone with CVS write permission can
commit it as far as I'm concerned, or you can remind me when I come
back from vacation.
--
Dave Abrahams
Boost Consulting
www.boost-consulting.com
More information about the Cplusplus-sig
mailing list