dave at boost-consulting.com
Thu Jul 21 15:34:41 CEST 2005
"Ralf W. Grosse-Kunstleve" <rwgk at yahoo.com> writes:
> Dave, could you please briefly review my patch? It is still very simple:
> forward class list in function.hpp + list signatures(bool
> show_return_type=false) const; declaration;
It's good practice to supply the user with everything he needs to use
a function declared in a given header. That would mean including the
full definition of list. Any reason not to?
> in function.cpp I've move some code
> from the body of argument_error() to the new signatures() function and I've
> patched the body of function_get_doc() to append the result of signatures().
It would be nice if the if(show_return_type) statement appeared to
have less apparent boilerplate repetition in its two branches, but
aside from that it seems fine.
Thanks for doing this!
Naturally, it can't go on the trunk until after 1.33 is released.
More information about the Cplusplus-sig