[Cryptography-dev] Landing AES

[Hynek Schlawack]

> We've slowed a bit in the last week or so. I want to get the AES patch landed so we can get the momentum back up (https://github.com/alex/cryptography/pull/28). There's a few outstanding issues we need to resolve:
> 
> * How the heck do we test error conditions in OpenSSL? OpenSSL is totally negligent in how we reproduce them. Should we monkeypatching the cffi functions to return error codes so we can at least test our code paths?

That sounds rather sketchy TBH but I don't know the innards of both.

> * Since the BlockCipher object doesn't know if it's in encrypt or decrypt mode until the first call it can't really initialize itself in the constructor. Is that fine?

I see two options:

 1. Explicit factory methods.
 2. Init on first use.

I tend to prefer 1., ideally with separate types. I love me some types.

—h
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/cryptography-dev/attachments/20130827/3a9ab1bd/attachment.html>