[Cython] Pyregr regressions

[Vitja Makarov]

2011/10/15 Stefan Behnel <stefan_ml at behnel.de>:
> Vitja Makarov, 15.10.2011 11:26:
>>
>> Recent commits to the master introduced pyregr regressions. You can
>> see it here, just sort by age:
>>
>>
>> https://sage.math.washington.edu:8091/hudson/job/cython-devel-tests-pyregr/BACKEND=c,PYVERSION=py27/33/testReport/
>
> I fixed the ones I had introduced, thanks for noting.
>
>
>> Here is one example:
>> ======================================================================
>> ERROR: runTest (__main__.CythonPyregrTestCase)
>> compiling (c) and running test_pipes
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>   File "runtests.py", line 679, in run
>>     self.runCompileTest()
>>   File "runtests.py", line 491, in runCompileTest
>>     self.test_directory, self.expect_errors, self.annotate)
>>   File "runtests.py", line 656, in compile
>>     self.assertEquals(None, unexpected_error)
>> AssertionError: None != u"39:14: Object of type '<unspecified>' has no
>> attribute 'open'"
>
> Not sure where that comes from, looks like a type inference bug.
>

GIT bisect could help here:

Error compiling Cython file:
------------------------------------------------------------
...

    def testSimplePipe3(self):
        file(TESTFN, 'w').write('hello world #2')
        t = pipes.Template()
        t.append(s_command + ' < $IN', pipes.FILEIN_STDOUT)
        with t.open(TESTFN, 'r') as f:
             ^
------------------------------------------------------------

/home/vitja/python/2.7/lib/python2.7/test/test_pipes.py:39:14: Object
of type '<unspecified>' has no attribute 'open'
7445f6fcdf760215f0e472d79570a48e74382818 is the first bad commit
commit 7445f6fcdf760215f0e472d79570a48e74382818
Author: Stefan Behnel <scoder at users.berlios.de>
Date:   Fri Oct 14 21:25:31 2011 +0200

    support for inlining the __enter__() method call in with statements

:040000 040000 970f19cc0f9e377ccfcf6f8d154cdb21f4d86556
1e298400e802a9edaba5fee32020132e3d08056f M	Cython
:040000 040000 795b066ed29ee8cfd0680b7f504cf281ac8d8dbd
a742911fe33b085fc484431714910e3fc263eece M	tests
bisect run success



>
>> May be it's a good idea to check for pyregr regressions as well as for
>> regular tests failures before merging into master?
>
> Well, sure. The problem is that it's much easier to see when a test turns
> from blue to yellow or red, than it is to see that a test turns from yellow
> to, well, yellow.
>
> I agree that it's generally worth looking through the results after a push
> and especially after a merge. Jenkins quite prominently complains about
> additional test failures in the build history:
>
> https://sage.math.washington.edu:8091/hudson/view/cython-devel/builds
>
> Throwing an eye on that page after the build/test jobs have run should help
> in spotting most regressions.
>

Pyregr tests are very helpful to find out that something is going
wrong with your changes.

-- 
vitja.