[Cython] overwriting pull requests and the related discussion

mark florisson markflorisson88 at gmail.com
Wed Feb 15 10:54:20 CET 2012


On 15 February 2012 09:37, Stefan Behnel <stefan_ml at behnel.de> wrote:
> Hi,
>
> I'd like to suggest that instead of overwriting pull requests and all of
> their comments on github by pushing replaced commits over them, it would be
> better to keep any existing discussions accessible by rejecting the current
> pull request and creating a new one.
>
> Does that make sense for everyone?
>
> Stefan
> _______________________________________________
> cython-devel mailing list
> cython-devel at python.org
> http://mail.python.org/mailman/listinfo/cython-devel

Hm, rebasing + force pushing is very common for pull requests, does
that delete the inline (or all) comments?


More information about the cython-devel mailing list