[Cython] Broken C-API generation for ext modules

[Stefan Behnel]

Lisandro Dalcin, 23.02.2012 22:00:
> The commit below from Stefan broke C-API generation for extension
> modules. The problem is that the code of __Pyx_ImportModule() and
> __Pyx_ImportType() depeds on the #definition of
> __Pyx_PyIdentifier_FromString , and such #define is not emitted in
> C-API headers.
> 
> Stefan, given that __Pyx_PyIdentifier_FromString() is only used in
> __Pyx_ImportModule() and __Pyx_ImportType(), what's your opinion about
> just rolling back your commit?
> 
> 
> commit 500f9a40f5ad441c2c204d076cfc4f82a41d531b
> Author: Stefan Behnel
> Date:   Sat Sep 10 00:14:05 2011 +0200

That's impressively old for a broken feature.


>     minor code simplification in utility functions by using macro for
> Py2/3 dependent PyString/PyUnicode_FromString() calls

https://github.com/cython/cython/commit/5a31a3d8d38d9d266886916432f1ebe621a2bc69

I pushed a fix here. Looks like the capi tests didn't detect this, though...

Stefan