[Cython] 0.18 beta 1 released

[Stefan Behnel]

Arfrever Frehtes Taifersar Arahesis, 20.01.2013 18:07:
> 2013-01-20 16:48:35 Stefan Behnel napisał(a):
>> Arfrever Frehtes Taifersar Arahesis, 20.01.2013 13:59:
>>> There are 6 test failures.
>>> Failures in builtin_abs.__test__.int_abs might be related to new versions of GCC or glibc. I use GCC 4.7.2 and glibc 2.16.0.
>>> Failures in NumPy-related tests are probably related to new version of NumPy. I use NumPy 1.7.0rc1.
>>> Failures are identical with CPython 2.6, 2.7, 3.1, 3.2 and 3.3.
>>>
>>> Results with CPython 2.7:
>>>
>>> ======================================================================
>>> FAIL: int_abs (line 35) (builtin_abs.__test__)
>>> Doctest: builtin_abs.__test__.int_abs (line 35)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>   File "/usr/lib64/python2.7/doctest.py", line 2201, in runTest
>>>     raise self.failureException(self.format_failure(new.getvalue()))
>>> AssertionError: Failed doctest test for builtin_abs.__test__.int_abs (line 35)
>>>   File "/var/tmp/portage/dev-python/cython-0.18_beta1-r1000/work/Cython-0.18b1/tests-2.7/run/c/builtin_abs/builtin_abs.so", line unknown line number, in int_abs (line 35)
>>>
>>> ----------------------------------------------------------------------
>>> File "/var/tmp/portage/dev-python/cython-0.18_beta1-r1000/work/Cython-0.18b1/tests-2.7/run/c/builtin_abs/builtin_abs.so", line ?, in builtin_abs.__test__.int_abs (line 35)
>>> Failed example:
>>>     int_abs(-max_int-1) == abs(-max_int-1)
>>> Expected:
>>>     True
>>> Got:
>>>     False
>>
>> Ok, from the file system paths, this looks like 64bit Gentoo Linux.
>>
>> Could you apply the attached patch and report the result for this test
>> again? Just pass "--no-cpp builtin_abs" to the test runner.
>>
>> The test was originally written this way because the actual values change
>> depending on the system they run on, but it would still be good to see them
>> in the output in case of a failure.
>>
>> Since you mentioned your recent GCC version, do you see any C compiler
>> warnings in the output of this particular test (i.e. during the actual test
>> run, not in the final summary)? Maybe with "-Wall" in your CFLAGS?
> 
> No warnings for this particular test.
> 
> I have now tested with GCC 4.6.3 (by exporting CC="x86_64-pc-linux-gnu-gcc-4.6.3" and CXX="x86_64-pc-linux-gnu-g++-4.6.3")
> and builtin_abs.__test__.int_abs tests pass with GCC 4.6.3.

Thanks, I could reproduce it now.


> Result with GCC 4.7.2 after applying your patch:
> 
> ======================================================================
> FAIL: int_abs (line 35) (builtin_abs.__test__)
> Doctest: builtin_abs.__test__.int_abs (line 35)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/lib64/python2.7/doctest.py", line 2201, in runTest
>     raise self.failureException(self.format_failure(new.getvalue()))
> AssertionError: Failed doctest test for builtin_abs.__test__.int_abs (line 35)
>   File "/tmp/Cython-0.18b1/BUILD/run/c/builtin_abs/builtin_abs.so", line unknown line number, in int_abs (line 35)
> 
> ----------------------------------------------------------------------
> File "/tmp/Cython-0.18b1/BUILD/run/c/builtin_abs/builtin_abs.so", line ?, in builtin_abs.__test__.int_abs (line 35)
> Failed example:
>     int_abs(-max_int-1) == abs(-max_int-1)   or (max_int, int_abs(-max_int-1), abs(-max_int-1))
> Expected:
>     True
> Got:
>     (2147483647, 18446744071562067968L, 2147483648)

This should fix it:

https://github.com/cython/cython/commit/43fe5b88813bb051e89d9be61373cdc3b098d624

Thanks again!

Stefan