[Cython] [PATCH] explain how to compile C++ extensions up to Cython 0.21

Stefan Behnel stefan_ml at behnel.de
Fri Oct 31 13:44:29 CET 2014


Daniele Nicolodi schrieb am 31.10.2014 um 13:07:
> Thanks for applying the patch.
> I see that you applied it manually and not through git am or similar,
> otherwise my identity would have been recorded in the git metadata and
> you would not have to add my name to the commit log.

If I get a patch by email, I usually interpret it as: "here's a proposal,
please apply or change as you like, I don't care about being named", unless
stated otherwise.

Sorry for the misunderstanding.


> I don't mind, but I'm wondering what is the best way to contribute
> patches, to make your work easier. Should I go through a pull request on
> github?

If you want to appear in the history, then that's the way to go.


> I don't quite like this solution for trivial patches like that,
> because it often ends up requiring a merge, and all the merge commits
> make browsing the source code history harder.

Merges are so common in DVCSs that most of the time I don't even notice
them in the history. Except when someone else does the merge, as for pull
requests. Then the distinction between committing and merging is actually
relevant, as it shows which core developer takes responsibility for
accepting a foreign change to the main repo.

Stefan



More information about the cython-devel mailing list