[Distutils] bdist_inno again

[Bernhard Herzog]

Andrew Kuchling <akuchlin@mems-exchange.org> writes:

> On Mon, Sep 10, 2001 at 10:21:56PM +0200, M.-A. Lemburg wrote:
> >I think the bdist_rpm command should go a long way as template
> >for the bdist_inno command.
> 
> Also note patch #415226 on SourceForge, which creates a new base class
> for binary packaging.  I'd like comments on whether this patch is a
> good idea.

In principle it's a good idea, I think. I'm not so sure about the patch
as it is, though.

The script parameters (preinstall, postinstall, etc.) are probably unix
or even RPM specific. Their documentation explicitly says they're
"Bourne shell code".

It's also not clear whether their values are filenames (as in bdist_rpm)
or the actual code. The get_script method allows both (and even a list
of strings) and the ensure_script method appears to but doesn't do it
correctly (it tests for string first which will always be true even if
it's a filename; the correct implementation would probably just check
for string).

The run method doesn't seem to do any actual work and even hinders
derived classes in just extending it. ISTM that derived classes will
have to overwrite this method (in its current implementation)
completely.

Last not least, I agree with Martin's comment in the patch tracker that
the patch should also modify existing bdist commands.


   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Sketch                                 http://sketch.sourceforge.net/
MapIt!                                               http://mapit.de/