[Distutils] Re: cygwin build woes.
Jason Tishler
jason@tishler.net
Tue Jan 22 12:07:00 2002
Michael,
On Tue, Jan 22, 2002 at 02:57:45PM +0000, Michael Hudson wrote:
> Building from CVS, no shared modules build, because distutils is
> looking for libpython2.3.dll, which isn't being built.
>
> These lines in Lib/distutils/command/build_ext.py are the problem:
>
> elif sys.platform[:6] == "cygwin":
> template = "python%d.%d"
> pythonlib = (template %
> (sys.hexversion >> 24, (sys.hexversion >> 16) & 0xff))
> # don't extend ext.libraries, it may be shared with other
> # extensions, it is a reference to the original list
> return ext.libraries + [pythonlib]
>
> It would be better, IMHO, to write
>
> elif sys.platform[:6] == "cygwin":
> pythonlib = "python" + sys.version[:3]
> # don't extend ext.libraries, it may be shared with other
> # extensions, it is a reference to the original list
> return ext.libraries + [pythonlib]
>
> as sys.version and VERSION in configure.in are pretty much guaranteed
> to be in sync.
>
> Shall I check this in, or do you have a better idea?
The looks OK by me, but I feel that this is a question for the Distutils
list. Any opinions on Michael's proposal?
Thanks,
Jason