[Distutils] Patch for your setuptools issue

[Tarek Ziadé]

On Tue, Jun 2, 2009 at 12:00 AM, P.J. Eby <pje at telecommunity.com> wrote:
> At 09:39 PM 6/1/2009 +0200, Tarek Ziadé wrote:
>>
>> 2009/6/1 P.J. Eby <pje at telecommunity.com>:
>> > At 07:01 PM 6/1/2009 +0200, Tarek Ziadé wrote:
>> >>
>> >> Antoine,
>> >>
>> >> here's a patch for your issue.
>> >
>> > Hm.  Did you send this patch before?  I don't recall seeing it.
>> >
>>
>> No, I have just created it. I can add it to setuptools issue tracker
>> if you think it's useful
>
> The idea is useful; I think there might be another way to do it now that
> you've given me the idea.  I'd prefer to do it in a way that doesn't copy
> code, i.e., by having __getattr__ return something that makes the
> distutils-level behavior the same as before, but not by copying the old
> distutils code.  That having been said, this might be a good patch to go in
> the meantime.

I have pushed it here :  http://bugs.python.org/setuptools/issue76

the tests pass using previous python interpreters,

Although it fails with the current python trunk,
it seems that unittest.main behaves differently. I am cc'ing  Michael
for some insights because I think
this has been changed lately.


Traceback (most recent call last):
  File "setup.py", line 95, in <module>
    scripts = [],
  File "/Volumes/MacDev/svn.python.org/python-trunk/Lib/distutils/core.py",
line 149, in setup
    dist.run_commands()
  File "/Volumes/MacDev/svn.python.org/python-trunk/Lib/distutils/dist.py",
line 926, in run_commands
    self.run_command(cmd)
  File "/Volumes/MacDev/svn.python.org/python-trunk/Lib/distutils/dist.py",
line 945, in run_command
    cmd_obj.run()
  File "/Volumes/MacDev/svn.python.org/setuptools/setuptools/command/test.py",
line 121, in run
    self.with_project_on_sys_path(self.run_tests)
  File "/Volumes/MacDev/svn.python.org/setuptools/setuptools/command/test.py",
line 101, in with_project_on_sys_path
    func()
  File "/Volumes/MacDev/svn.python.org/setuptools/setuptools/command/test.py",
line 134, in run_tests
    unittest.main(
  File "/Volumes/MacDev/svn.python.org/python-trunk/Lib/unittest.py",
line 1662, in __init__
    self.runTests()
  File "/Volumes/MacDev/svn.python.org/python-trunk/Lib/unittest.py",
line 1744, in runTests
    self.result = testRunner.run(self.test)
AttributeError: 'NoneType' object has no attribute 'run'



>
> I am thinking, btw, that it's time to retire the 0.6 stable branch and begin
> only doing new stuff on the trunk, anyway.

+1

Maybe a final 0.6 release could be done, including the svn 1.6 patch
(or a patch to make the last 0.6.x release not suffering from svn
changes anymore
e.g. by adding a plugin behaviour)