[Distutils] buildout/distribute recursion error fixed

[Tarek Ziadé]

On Tue, Nov 10, 2009 at 3:00 PM, Reinout van Rees <reinout at vanrees.org> wrote:
[..]
>>
>> Before it's merged in trunk and eventually released, we need to :
>>
>> - add a test demonstrating this bug in easy_install.txt
>
> Buildout's test aren't setup to test this kind of things directly.  I *did*
> add a test to easy_install.txt that tests whether the offending _get_dist()
> (which starts the recursion) gets called.  This fails before my fix and
> succeeds afterwards.
>
> On Tarek's suggestion, I moved the test out of easy_install.txt to a separate
> file to keep the corner case test out of the user documentation.
>

Sounds enough,

>> - manually test the various scenarii (these are not fully covered with
>> zc.buildout unittests because the assmption is made that python don't
>> have setuptools installed):
>>
>>     - nude python, buildout without --distribute, plone buildout cfg file
>>     - python with setuptools, buildout witout --distribute, plone
>> buildout cfg file
>>     - python with distribute < 0.6.8, buildout witout --distribute,
>> plone buildout cfg file
>>     - these 3 tests *with* --distribute
>
> I did not test all the variants, that would cost me waaaay too much time for
> such a small fix.  To be honest.
>
> I did reproduce it with setuptools + distribute with and without the fix with
> the development buildout itself.  That executes the changed code point enough.

Can you merge it into trunk ?

Thanks

Tarek