[Distutils] [final version?] PEP 513 - A Platform Tag for Portable Linux Built Distributions
Nick Coghlan
ncoghlan at gmail.com
Sat Jan 30 03:58:08 EST 2016
On 30 January 2016 at 18:37, Nathaniel Smith <njs at pobox.com> wrote:
> On Fri, Jan 29, 2016 at 11:52 PM, Nick Coghlan <ncoghlan at gmail.com> wrote:
>> On 30 January 2016 at 09:29, Nathaniel Smith <njs at pobox.com> wrote:
>>> Hi all,
>>>
>>> I think this is ready for pronouncement now -- thanks to everyone for
>>> all their feedback over the last few weeks!
>>>
>>> The only change relative to the last posting is that we rewrote the
>>> section on "Platform detection for installers", to switch to letting
>>> distributors explicitly control manylinux1 compatibility by means of a
>>> _manylinux module.
>>
>> In terms of the proposal itself, I think this version is excellent :)
>>
>> However, I realised that there's an implicit assumption we've been
>> making that really should be spelled out explicitly: manylinux1 wheels
>> targeting CPython 3.2 and earlier need to be compiled against a
>> CPython built in wide Unicode mode, and in those cases, the detection
>> of manylinux1 compatibility at the platform level should include
>> checking for "sys.maxunicode > 0xFFFF".
>
> Doh, excellent catch!
>
> I've just pushed the obvious update to handle this directly to the
> copy of the PEP in the manylinux repository.
>
> Diff: https://github.com/manylinux/manylinux/commit/2e49cd16b89e0d6e84a5dc98ddb1a916968b73bc
>
> New text in full:
> https://raw.githubusercontent.com/manylinux/manylinux/2e49cd16b89e0d6e84a5dc98ddb1a916968b73bc/pep-513.rst
>
> I haven't sent to the PEP editors, because they already have another
> diff from me sitting in their inboxes and I'm not sure how to do this
> in a way that doesn't confuse things :-)
I applied both this iteration and the previous one to the PEPs repo in
order to review it, so modulo caching issues, this latest draft is
live now.
I also think this version covers everything we need it to cover, so
I'm going to mark it as Active and point to this post as the
resolution :)
Cheers,
Nick.
--
Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
More information about the Distutils-SIG
mailing list