[docs] urllib data URL recipe (issue 16423)

pitrou at free.fr pitrou at free.fr
Sat Nov 24 17:51:04 CET 2012


Thanks for the updated patch. There are a couple of very minor issues,
but I can handle them myself.



http://bugs.python.org/review/16423/diff/6609/Doc/library/urllib.request.rst
File Doc/library/urllib.request.rst (right):

http://bugs.python.org/review/16423/diff/6609/Doc/library/urllib.request.rst#newcode349
Doc/library/urllib.request.rst:349: .. class:: DataHandler()
You need a `versionadded` tag below.

http://bugs.python.org/review/16423/diff/6609/Doc/library/urllib.request.rst#newcode1395
Doc/library/urllib.request.rst:1395: 1.0), FTP, local files, and data
URLs.
And here you probably need a `versionchanged` tag for the addition of
data URL support.

http://bugs.python.org/review/16423/diff/6609/Lib/urllib/request.py
File Lib/urllib/request.py (right):

http://bugs.python.org/review/16423/diff/6609/Lib/urllib/request.py#newcode1559
Lib/urllib/request.py:1559: scheme, data = url.split(":",1)
PEP8 nit: space after commas.

http://bugs.python.org/review/16423/


More information about the docs mailing list