[docs] Code, test, and doc review for PEP-0435 Enum (issue 17947)

alex.gaynor at gmail.com alex.gaynor at gmail.com
Fri May 10 20:24:06 CEST 2013


A few small notes (I didn't do a complete review yet)


http://bugs.python.org/review/17947/diff/8110/Lib/enum.py
File Lib/enum.py (right):

http://bugs.python.org/review/17947/diff/8110/Lib/enum.py#newcode55
Lib/enum.py:55: return self
Real properties don't mutate on setter/deleter/getter, but rather return
a new instance, I think this should probably mimic that behavior.

http://bugs.python.org/review/17947/diff/8110/Lib/enum.py#newcode68
Lib/enum.py:68: def __setitem__(self, key, something):
I think `value` is a more common name to use than `something`.

http://bugs.python.org/review/17947/


More information about the docs mailing list