[docs] Code, test, and doc review for PEP-0435 Enum (issue 17947)

ethan at stoneleaf.us ethan at stoneleaf.us
Sun May 12 14:49:55 CEST 2013


http://bugs.python.org/review/17947/diff/8105/Lib/enum.py
File Lib/enum.py (right):

http://bugs.python.org/review/17947/diff/8105/Lib/enum.py#newcode244
Lib/enum.py:244: class_name = value  # better name for a name than value
;)
On 2013/05/12 14:47:01, stoneleaf wrote:
> On 2013/05/10 16:02:43, eli.bendersky wrote:
> > I'd suggest a new method here:
> > 
> > _make_enum_from_names(name, member_names, ....)
> 
> Not much happens before this point, and everything after this is about
making
> the enum class -- I don't see that breaking off 90% of this method
into another
> buys us much.

Okay, it buys us better subclassing support.  Made new helper method
`_create`

http://bugs.python.org/review/17947/


More information about the docs mailing list