[docs] Code, test, and doc review for PEP-0435 Enum (issue 17947)

zachary.ware at gmail.com zachary.ware at gmail.com
Sat May 11 06:42:08 CEST 2013


http://bugs.python.org/review/17947/diff/8113/Lib/test/test_enum.py
File Lib/test/test_enum.py (right):

http://bugs.python.org/review/17947/diff/8113/Lib/test/test_enum.py#newcode9
Lib/test/test_enum.py:9: _errors = []
No longer needed.

http://bugs.python.org/review/17947/diff/8113/Lib/test/test_enum.py#newcode16
Lib/test/test_enum.py:16: Stooges = exc
Not quite what I had in mind, but it does seem to work.  But may I ask
what your justification for keeping all the try/excepts and now the
extra type checking in the tests is?  If you've got a good reason, this
method works for me; I just think it could all be a whole lot simpler.

http://bugs.python.org/review/17947/diff/8113/Lib/test/test_enum.py#newcode64
Lib/test/test_enum.py:64: self.assertFalse(_errors)
This test is now useless, it can go.

http://bugs.python.org/review/17947/


More information about the docs mailing list